-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow stopping respond callbacks midway #5962
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5962 +/- ##
==========================================
- Coverage 84.67% 84.67% -0.01%
==========================================
Files 291 291
Lines 43586 43722 +136
==========================================
+ Hits 36907 37020 +113
- Misses 6679 6702 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Still seeing some errors in the tests. |
Okay fixed the issue: generators are "finished" prematurely from the POV of a future, so I had to introduce a |
Closes #5943
Upon sending a message, if the callback is async, the Send button gets hidden and the Stop button appears. Clicking it will cancel the callback midway.
Screen.Recording.2023-11-30.at.3.58.11.PM.mov
Makes it so that sync tasks are submitted to a separate thread so it's cancellable.
Screen.Recording.2023-12-04.at.10.58.51.PM.mov
Also, I think I made it more performant for sync too.