Fix post callback for default #5998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5998 +/- ##
===========================================
- Coverage 83.10% 22.62% -60.48%
===========================================
Files 291 291
Lines 43522 43546 +24
===========================================
- Hits 36170 9854 -26316
- Misses 7352 33692 +26340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ahuang11
commented
Dec 6, 2023
| ): | ||
| """ | ||
| Wrap the callback and post callback around the default callback. | ||
| """ | ||
| def decorate(default_callback: Callable): | ||
| def wrapper(self, event: param.parameterized.Event): | ||
| if name == "send" and not self.active_widget.value: | ||
| # don't trigger if no message to prevent duplication |
There was a problem hiding this comment.
This is primarily because value gets reset to "", and re-triggers the callback without this clause
philippjfr
approved these changes
Dec 6, 2023
philippjfr
reviewed
Dec 6, 2023
| clear_button = chat_interface._input_layout[-1] | ||
| chat_interface.send("This shouldn't show up!", respond=False) | ||
| clear_button.param.trigger("clicks") | ||
| time.sleep(0.5) |
There was a problem hiding this comment.
Should have reviewed this more closely, time.sleep should not be used in the test suite (except for very rare cases). Use the wait_until utility.
philippjfr
pushed a commit
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes post callback for existing buttons.
Also, attaches callback/post_callback to auto send on value change.
Screen.Recording.2023-12-05.at.4.48.38.PM.mov