Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make panel.chat.langchain import lazy #6056

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Make panel.chat.langchain import lazy #6056

merged 3 commits into from
Dec 15, 2023

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 15, 2023

Screenshot 2023-12-15 at 15 37 16

Fixes #6000

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a9a5067) 83.11% compared to head (507b01b) 83.08%.
Report is 2 commits behind head on main.

Files Patch % Lines
panel/chat/__init__.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6056      +/-   ##
==========================================
- Coverage   83.11%   83.08%   -0.04%     
==========================================
  Files         295      295              
  Lines       43960    43976      +16     
==========================================
- Hits        36539    36536       -3     
- Misses       7421     7440      +19     
Flag Coverage Δ
ui-tests 38.21% <40.00%> (-0.06%) ⬇️
unitexamples-tests 72.71% <40.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

panel/models/layout.ts Outdated Show resolved Hide resolved
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
@philippjfr philippjfr merged commit ae2390f into main Dec 15, 2023
10 of 13 checks passed
@philippjfr philippjfr deleted the lazify_langchain branch December 15, 2023 16:45
philippjfr added a commit that referenced this pull request Dec 15, 2023
* Make panel.chat.langchain import lazy

* Add attribute error

* Update panel/models/layout.ts

Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>

---------

Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not import langchain by default
2 participants