Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Material notebook .show() call #6137

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Fix Material notebook .show() call #6137

merged 1 commit into from
Dec 27, 2023

Conversation

philippjfr
Copy link
Member

Inconsistent with other notebooks and appears to be causing errors in the windows test suite.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9237e1e) 84.64% compared to head (b3a64be) 84.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6137      +/-   ##
==========================================
- Coverage   84.64%   84.57%   -0.08%     
==========================================
  Files         296      296              
  Lines       44184    44184              
==========================================
- Hits        37401    37369      -32     
- Misses       6783     6815      +32     
Flag Coverage Δ
ui-tests 40.72% <ø> (-0.01%) ⬇️
unitexamples-tests 72.47% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit c08c4eb into main Dec 27, 2023
15 checks passed
@philippjfr philippjfr deleted the material_ref_doc_fix branch December 27, 2023 23:44
philippjfr added a commit that referenced this pull request Jan 17, 2024
This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant