Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HoloViz logos as ChatMessage avatars #6348

Merged
merged 8 commits into from
Mar 16, 2024
Merged

Add HoloViz logos as ChatMessage avatars #6348

merged 8 commits into from
Mar 16, 2024

Conversation

ahuang11
Copy link
Contributor

Makes it more convenient to just use user="hvplot" or user="lumen" without manually setting avatar.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 40.27%. Comparing base (c89841a) to head (1691a8c).

Files Patch % Lines
panel/chat/message.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6348       +/-   ##
===========================================
- Coverage   82.92%   40.27%   -42.66%     
===========================================
  Files         313      313               
  Lines       45834    45842        +8     
===========================================
- Hits        38007    18462    -19545     
- Misses       7827    27380    +19553     
Flag Coverage Δ
ui-tests 40.09% <76.92%> (-0.01%) ⬇️
unitexamples-tests 22.23% <61.53%> (-48.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all the avatars not be available from cdn?

  1. we are in control
  2. loads faster?

@ahuang11
Copy link
Contributor Author

That sounds good to me; I don't have experience uploading to CDN / using CDN resources though. Is it documented somewhere?

panel/chat/message.py Outdated Show resolved Hide resolved
@ahuang11
Copy link
Contributor Author

image

panel/chat/message.py Outdated Show resolved Hide resolved
panel/chat/message.py Outdated Show resolved Hide resolved
panel/chat/message.py Outdated Show resolved Hide resolved
panel/chat/message.py Outdated Show resolved Hide resolved
@philippjfr philippjfr merged commit d56c2a5 into main Mar 16, 2024
14 of 15 checks passed
@philippjfr philippjfr deleted the add-holoviz-logos branch March 16, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants