-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HoloViz logos as ChatMessage avatars #6348
Conversation
Makes it more convenient
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6348 +/- ##
===========================================
- Coverage 82.92% 40.27% -42.66%
===========================================
Files 313 313
Lines 45834 45842 +8
===========================================
- Hits 38007 18462 -19545
- Misses 7827 27380 +19553
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all the avatars not be available from cdn?
- we are in control
- loads faster?
That sounds good to me; I don't have experience uploading to CDN / using CDN resources though. Is it documented somewhere? |
Makes it more convenient to just use
user="hvplot"
oruser="lumen"
without manually setting avatar.