Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modal overflow and resizing issues #6355

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Fix modal overflow and resizing issues #6355

merged 3 commits into from
Feb 19, 2024

Conversation

philippjfr
Copy link
Member

Fixes #6353

  • Add tests

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11a1504) 83.63% compared to head (3737718) 82.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6355      +/-   ##
==========================================
- Coverage   83.63%   82.00%   -1.64%     
==========================================
  Files         305      305              
  Lines       45559    45559              
==========================================
- Hits        38105    37362     -743     
- Misses       7454     8197     +743     
Flag Coverage Δ
ui-tests 36.14% <ø> (-3.51%) ⬇️
unitexamples-tests 71.64% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

panel/models/tabulator.ts Outdated Show resolved Hide resolved
@philippjfr philippjfr merged commit e5955d3 into main Feb 19, 2024
12 of 15 checks passed
@philippjfr philippjfr deleted the modal_resize branch February 19, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

layout='fit_data_stretch' on Tabulator does not work in modal
1 participant