Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run() to StoppableThread class #645

Merged
merged 1 commit into from Sep 13, 2019
Merged

Conversation

lsetiawan
Copy link
Contributor

@lsetiawan lsetiawan commented Sep 12, 2019

Overview

This PR adds a run() method to the StoppableThread class. The method overrides the default run() from threading library. The result from _target is used stop the bokeh server completely, thereby releasing the port.

This should fix #634.

@friedrichknuth has tested this with his work, and it seemed to solve the issue.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 13, 2019

Thanks, this is hugely appreciated.

@philippjfr philippjfr merged commit 97ae345 into holoviz:master Sep 13, 2019
1 of 2 checks passed
@lsetiawan lsetiawan deleted the release_port branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants