Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle updates to Boolean indicators #6481

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Throttle updates to Boolean indicators #6481

merged 5 commits into from
Mar 11, 2024

Conversation

philippjfr
Copy link
Member

When working in a template the loading spinner is continuously updated to the point that it dominates Websocket traffic for many apps. By implementing simple throttling for boolean indicator events we can avoid a lot of that traffic and reduce the flicker of the indicator itself.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 82.07%. Comparing base (5578f98) to head (e674a76).
Report is 1174 commits behind head on main.

Files Patch % Lines
panel/widgets/indicators.py 40.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6481      +/-   ##
==========================================
- Coverage   82.75%   82.07%   -0.68%     
==========================================
  Files         239      312      +73     
  Lines       34507    46096   +11589     
==========================================
+ Hits        28555    37832    +9277     
- Misses       5952     8264    +2312     
Flag Coverage Δ
ui-tests 36.65% <22.22%> (-1.47%) ⬇️
unitexamples-tests 71.48% <40.00%> (-2.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 21d19a9 into main Mar 11, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the throttle_indicators branch March 11, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant