Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Tabulator.selection is consisting across pagination and filtering #7058

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 2, 2024

Fixes #2907
Fixes #3670
Fixes #6004

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 74.46809% with 24 lines in your changes missing coverage. Please review.

Project coverage is 82.21%. Comparing base (7c90f7b) to head (360812b).
Report is 3 commits behind head on main.

Files Patch % Lines
panel/tests/ui/widgets/test_tabulator.py 57.89% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7058      +/-   ##
==========================================
+ Coverage   81.79%   82.21%   +0.42%     
==========================================
  Files         326      326              
  Lines       48350    48464     +114     
==========================================
+ Hits        39546    39847     +301     
+ Misses       8804     8617     -187     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 3fe6307 into main Aug 2, 2024
15 checks passed
@philippjfr philippjfr deleted the tabulator-selection-index-consistency branch August 2, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant