Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove object attribute from Panel class #743

Merged
merged 1 commit into from Nov 7, 2019

Conversation

kleavor
Copy link
Contributor

@kleavor kleavor commented Nov 6, 2019

Closes #546

Inheriting classes define this attribute individually.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Nov 6, 2019

Thanks! I think the _get_objects method should probably also be moved to the ListPanel class and Tabs should probably not inherit from ListPanel.

@philippjfr philippjfr merged commit 1fba4be into holoviz:master Nov 7, 2019
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants