Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fixes to param API usage #998

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Additional fixes to param API usage #998

merged 2 commits into from
Jan 23, 2020

Conversation

jlstevens
Copy link
Contributor

Further updates to param usage in panel. Please don't merge yet as there may be more that I find as I fix the warnings found by the holoviews tests!

@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #998 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
+ Coverage   85.85%   86.08%   +0.22%     
==========================================
  Files          99       99              
  Lines       11301    11426     +125     
==========================================
+ Hits         9703     9836     +133     
+ Misses       1598     1590       -8
Impacted Files Coverage Δ
panel/pane/holoviews.py 84.55% <100%> (ø) ⬆️
panel/config.py 53.08% <100%> (ø) ⬆️
panel/widgets/base.py 83.11% <100%> (ø) ⬆️
panel/links.py 84.14% <100%> (ø) ⬆️
panel/widgets/select.py 94.52% <0%> (+0.35%) ⬆️
panel/param.py 94.02% <0%> (+3.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaecd6b...c5d87eb. Read the comment docs.

@philippjfr philippjfr merged commit 0c924a1 into master Jan 23, 2020
@philippjfr philippjfr deleted the param_API_fixes branch January 31, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants