Skip to content

LinearClosureMorphismNC now does a cheap assertion #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
Merged

LinearClosureMorphismNC now does a cheap assertion #1796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91a0cc1
disambiguate local variables
mohamed-barakat Sep 1, 2025
0ae8fd3
LinearClosureMorphismNC now does a cheap assertion
mohamed-barakat Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LinearClosuresForCAP/PackageInfo.g
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ SetPackageInfo( rec(

PackageName := "LinearClosuresForCAP",
Subtitle := "Linear closures",
Version := "2025.08-04",
Version := "2025.09-01",
Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
License := "GPL-2.0-or-later",

Expand Down
15 changes: 10 additions & 5 deletions LinearClosuresForCAP/gap/LinearClosure.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,12 +354,17 @@ end );
InstallOtherMethodForCompilerForCAP( LinearClosureMorphismNC,
[ IsLinearClosure, IsLinearClosureObject, IsList, IsList, IsLinearClosureObject ],
function( category, source, coefficients, support_morphisms, range )
local underlying_category;

underlying_category := UnderlyingCategory( category );

#% CAP_JIT_DROP_NEXT_STATEMENT
Assert( 0, ForAll( support_morphisms, mor -> IsIdenticalObj( CapCategory( mor ), underlying_category ) ) );

return CreateCapCategoryMorphismWithAttributes( category,
source, range,
CoefficientsList, coefficients,
SupportMorphisms, support_morphisms
);
source, range,
CoefficientsList, coefficients,
SupportMorphisms, support_morphisms );

end );

Expand Down Expand Up @@ -638,7 +643,7 @@ InstallGlobalFunction( INSTALL_FUNCTIONS_FOR_LINEAR_CLOSURE,

coeffs := ListX( CoefficientsList( alpha ), CoefficientsList( beta ), { a,b } -> a * b );

supp := ListX( SupportMorphisms( alpha ), SupportMorphisms( beta ), { alpha, beta } -> PreCompose( underlying_category, alpha, beta ) );
supp := ListX( SupportMorphisms( alpha ), SupportMorphisms( beta ), { a, b } -> PreCompose( underlying_category, a, b ) );

return MorphismConstructor( cat, Source( alpha ), Pair( coeffs, supp ), Range( beta ) );

Expand Down