Skip to content

Conversation

zickgraf
Copy link
Member

The changes in this PR are straight-foward, so I will merge the PR without additional review if and when the CI succeeds.

@zickgraf zickgraf changed the title Improvments to the compiler and to the compilation of CategoryOfColumns Improvements to the compiler and to the compilation of CategoryOfColumns Aug 25, 2021
@zickgraf zickgraf force-pushed the compiler_improvements branch from b57f8f1 to 5774adb Compare August 25, 2021 10:18
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #699 (8fead39) into master (36eec44) will increase coverage by 0.09%.
The diff coverage is 58.47%.

❗ Current head 8fead39 differs from pull request most recent head 5774adb. Consider uploading reports for the commit 5774adb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
+ Coverage   64.40%   64.49%   +0.09%     
==========================================
  Files         316      316              
  Lines       45084    44997      -87     
==========================================
- Hits        29038    29023      -15     
+ Misses      16046    15974      -72     
Impacted Files Coverage Δ
CAP/gap/MethodRecord.gi 81.69% <11.11%> (-0.16%) ⬇️
...gap/CategoryOfColumnsAsOppositeOfCategoryOfRows.gi 57.51% <14.28%> (+14.97%) ⬆️
FreydCategoriesForCAP/gap/CategoryOfRows.gi 44.71% <40.00%> (-0.35%) ⬇️
FreydCategoriesForCAP/gap/CategoryOfColumns.gi 46.15% <63.33%> (+0.32%) ⬆️
...recompiled_categories/MatrixCategoryPrecompiled.gi 73.24% <66.66%> (-0.05%) ⬇️
..._categories/OppositeOfMatrixCategoryPrecompiled.gi 45.97% <66.66%> (+0.21%) ⬆️
CompilerForCAP/gap/PrecompileCategory.gi 94.31% <85.18%> (-0.50%) ⬇️
CAP/PackageInfo.g 100.00% <100.00%> (ø)
CAP/gap/OppositeCategory.gi 92.30% <100.00%> (+0.09%) ⬆️
CompilerForCAP/PackageInfo.g 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36eec44...5774adb. Read the comment docs.

@zickgraf zickgraf merged commit 83cccba into homalg-project:master Aug 25, 2021
@zickgraf zickgraf deleted the compiler_improvements branch August 25, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant