Correct modbus commit validation, too strict on integers #109338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: modbus
small-pr
frenck
approved these changes
Feb 2, 2024
frenck
pushed a commit
that referenced
this pull request
Feb 2, 2024
emackinnon1
added a commit
to emackinnon1/core
that referenced
this pull request
Feb 2, 2024
* Bump deebot-client to 5.0.0 (home-assistant#109066) * Use right initial attribute value for demo climate (home-assistant#108719) * Add doors and charge cable binary sensors to Tessie (home-assistant#107172) * Add doors * Update homeassistant/components/tessie/strings.json Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * Add charge cable --------- Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * Bump tesla-powerwall to 0.5.1 (home-assistant#109069) * Extract foscam base entity for reuse (home-assistant#108893) * Extract foscam base entity for reuse * Cleanup * More cleanup * Cleanup constructor * Use more constants * Bump aiohttp to 3.9.3 (home-assistant#109025) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * Update apprise to 1.7.2 (home-assistant#109071) * Update colorlog to 6.8.2 (home-assistant#109072) * Bump python-matter-server to version 5.3.0 (home-assistant#109068) * Fix duplicate Windy values showing in automations state selector (home-assistant#108062) * Bump ZHA dependency zigpy to 0.60.7 (home-assistant#109082) * Code quality for Comelit tests (home-assistant#109077) * Don't remove zwave_js devices automatically (home-assistant#98145) * Update calendar tests to use mock entities instead of demo platform (home-assistant#105317) * Update calendar tests to use mock entities instead of demo platform * Add Generator type to fixture * Fix generator syntax --------- Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * Bump/flush mypy cache (home-assistant#109101) * Bump simplisafe-python to 2024.01.0 (home-assistant#109091) * Code quality for Shelly integration (home-assistant#109061) * Add missing abort message for Spotify (home-assistant#109102) * Shield for unregistered Spotify users * Shield for unregistered Spotify users * Add support for ignoring zwave_js device config file changes (home-assistant#108990) * Add support for ignoring zwave_js device config file changes * mistake * fixes * Small tweaks and add/update tests * Add configure option to Vodafone Station for consider home (home-assistant#108594) * Add configure option to Vodafone Station for consider home * add test * improve tests * reload on option change * Fix tessie tests (home-assistant#109113) * Fix device tracker test * Snapshot cleanup * Add person icon translations (home-assistant#109106) * Update attrs to 23.2.0 (home-assistant#109115) * Improve invalid error messages in the config flows (home-assistant#108075) * Add device tracker icon translations (home-assistant#109109) * Remove erroneous reference to Google from Calendar integration (home-assistant#109089) * Intents package combines sentences/responses per language (home-assistant#109079) * Bump pytechnove to 1.2.1 (home-assistant#109098) * Bump TechnoVE library to 1.2.0 * Bump TechnoVE library to 1.2.1 * Exclude unknown status from the options * Regenerate test_sensor.ambr for TechnoVE snapshot test --------- Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * Clean up Fritz options flow (home-assistant#109111) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Co-authored-by: Franck Nijhof <frenck@frenck.nl> * Bump python-matter-server to 5.3.1 (home-assistant#109118) * Add script icon translations (home-assistant#109107) Co-authored-by: Franck Nijhof <git@frenck.dev> * Add input boolean icon translations (home-assistant#109108) Co-authored-by: Franck Nijhof <git@frenck.dev> * Add missing status's to Nut (home-assistant#109085) * Update coverage to 7.4.1 (home-assistant#109116) * Clean up ZHA cover entity and add support for inverting cover entities derived from the window covering cluster (home-assistant#108238) * Fix readme images (home-assistant#108767) * Flow rate unit conversions and device class (home-assistant#106077) * Add volume flow rate conversions * Add missing translations * Adjust liter unit and add gallons per minute * Adjust to min instead of m for minutes * Add matching class for number * Add some tests for number and sensor platform * Add deprecated constants * Add explicit list of flow rate for check This reverts commit 105171a. * Add TURN_OFF and TURN_ON to ClimateEntityFeature (home-assistant#101673) * Add ClimateEntityFeature.TURN_OFF * Fixes * Fixes * wording * Change to services * Fixing * Fixing * Last bits * Review comments * Add hvac_modes checks * Fixes * Add tests * Review comments * Update snapshots * balboa * coolmaster * ecobee * mqtt * nest * plugwise * smarttub * whirlpool * zwave_js * fix test climate * test climate * zwave * nexia * nuheat * venstar * tado * smartthings * self.hvac_modes not None * more tests * homekit_controller * homekit controller snapshot * Pass default SSLContext instances to Octoprint custom HTTP sessions (home-assistant#105351) * Reduce overhead for google calendar state updates (home-assistant#108133) * Fix SleepIQ setting FootWarmer timer (home-assistant#108433) * Fixing foot warmer timer bug * Fixing bug where temperature wasnt assigned to number entity causing tests to fail * Fix zha illuminance measured value mapping (home-assistant#108547) * Bump yolink-api to 0.3.6 fix aiomqtt breaking changes (home-assistant#108555) * bump yolink-api to 0.3.5 * bump yolink-api to 0.3.6 * Update openerz-api to 0.3.0 (home-assistant#108575) * Bump aiovodafone to 0.5.4 (home-assistant#108592) * Bump airthings-ble to 0.6.0 (home-assistant#108612) * Fix alexa fails reporting the state in specific cases (home-assistant#108743) * Fix alexa fails reporting the state in specific cases * More cases * Reduce log level of ZHA endpoint handler init (home-assistant#108749) * Reduce the log level of endpoint handler init failure to debug * Reduce log level in unit test * Fix google_assistant climate modes might be None (home-assistant#108793) * Fix unhandled exception on humidifier intent when available_modes is None (home-assistant#108802) * Fix processing supported color modes for emulated_hue (home-assistant#108803) * Reduce log level for creating ZHA cluster handler (home-assistant#108809) * Fix stalls in config flow of APCUPSD (home-assistant#108931) Fix deadlock in config flow of APCUPSD * Add strings to Sensirion BLE (home-assistant#109001) * Fix entity naming for heatpump heatings in ViCare (home-assistant#109013) Update strings.json * Bump aiohttp to 3.9.3 (home-assistant#109025) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * Bump ZHA dependency zigpy to 0.60.7 (home-assistant#109082) * Add missing abort message for Spotify (home-assistant#109102) * Shield for unregistered Spotify users * Shield for unregistered Spotify users * Bump version to 2024.1.6 * Add TURN_ON/OFF ClimateEntityFeature for Shelly (home-assistant#108967) * Update climate snapshots to fix CI (home-assistant#109141) * Add support for custom integrations in Analytics Insights (home-assistant#109110) * Add TURN_ON/OFF ClimateEntityFeature for smartthings (home-assistant#108979) * Add TURN_ON/OFF ClimateEntityFeature for ZHA (home-assistant#108978) * Add TURN_ON/OFF ClimateEntityFeature for Balboa (home-assistant#109139) * Add TURN_ON/OFF ClimateEntityFeature for Vicare (home-assistant#109135) * Add TURN_ON/OFF ClimateEntityFeature for TOLO Sauna (home-assistant#108965) * Add TURN_ON/OFF ClimateEntityFeature for Overkiz (home-assistant#109132) * Add TURN_ON/OFF ClimateEntityFeature for Sensibo (home-assistant#108962) * Add TURN_ON/OFF ClimateEntityFeature for IntesisHome (home-assistant#109134) * Add TURN_ON/OFF ClimateEntityFeature for Fritzbox (home-assistant#108964) * Add TURN_ON/OFF ClimateEntityFeature for Adax (home-assistant#108966) * Add TURN_ON/OFF ClimateEntityFeature for Vera (home-assistant#108969) * Add TURN_ON/OFF ClimateEntityFeature for Nexia (home-assistant#108970) Co-authored-by: Franck Nijhof <git@frenck.dev> * Add TURN_ON/OFF ClimateEntityFeature for Advantage Air (home-assistant#108971) * Add TURN_ON/OFF ClimateEntityFeature for CoolMasterNet (home-assistant#108972) * Add TURN_ON/OFF ClimateEntityFeature for Netatmo (home-assistant#108973) * Add TURN_ON/OFF ClimateEntityFeature for Mill (home-assistant#108977) * Update Ecovacs binary sensor keys (home-assistant#109145) * Add check for valid initial_suggested_unit (home-assistant#108902) Co-authored-by: Erik Montnemery <erik@montnemery.com> * Set TURN_ON and TURN_OFF feature on MQTT climate entities (home-assistant#109146) * Update reload icons for automation and person service (home-assistant#109147) * Add event entity to Xiaomi-BLE integration (home-assistant#108811) * Add TURN_ON/OFF ClimateEntityFeature for HomeKit Device (home-assistant#109137) * Simplify MQTT device triggers in automations (home-assistant#108309) * Simplify MQTT device trigger * Add test non unique trigger_id * Adjust deprecation warning * Make discovery_id optional * refactor double if * Improve validation, add tests and deprecation comments * Avoid breaking change * Inmprove error message * Match on discovery_id instead of discovery_info * Revert an unrelated change * follow up comments * Add comment and test on device update with non unique trigger * Update homeassistant/components/mqtt/device_trigger.py Co-authored-by: Erik Montnemery <erik@montnemery.com> * Update homeassistant/components/mqtt/device_trigger.py Co-authored-by: Erik Montnemery <erik@montnemery.com> --------- Co-authored-by: Erik Montnemery <erik@montnemery.com> * Speed up listing issues via the repairs websocket api (home-assistant#109149) * Add missing ZHA metering device types (home-assistant#109126) * Update smartenergy.py metering_device_type enums * Added missing enum 127 * Enum 127 is also electric metering type * Meter type constants and status enums in smartenergy cluster handler Addresses home-assistant#109126 (comment) Whilst I have the code open I've also added status handlers for the non-electrical meter types. * New tests for different metering device type statuses * Filter ZHA light group color modes (home-assistant#108861) Ensure ZHA light color modes have proper defaults and are filtered * Remove Shelly RSSI sensor if Wi-FI is not configured (home-assistant#108390) * Remove Shelly RSSI sensor if Wi-FI is not configured * fix tests * Create an issue when database backups fail because the system runs out of resources (home-assistant#109020) * Fix precipitation typo in icons (home-assistant#109156) * Fix ZHA cover inversion handling missing attributes (home-assistant#109151) * Allow `window_covering_type` to be `None` * Create a `window_covering_mode` attribute and simplify inversion switch * Revert "Create a `window_covering_mode` attribute and simplify inversion switch" This reverts commit 048d649. * check both config status and mode * coverage --------- Co-authored-by: David Mulcahey <david.mulcahey@icloud.com> * Handle deprecated cloud tts voice (home-assistant#109124) * Handle deprecated cloud tts voice * Add test * Fix test logic * Add breaks in ha version * Adjust translation string * Add a repair issue for Shelly devices with unsupported firmware (home-assistant#109076) Co-authored-by: J. Nick Koston <nick@koston.org> * Bump zha-quirks to 0.0.110 (home-assistant#109161) * Bump zha-quirks to 0.0.110 * Reflect removal of `IasWd` cluster for Heiman sensor in tests * Add Nextcloud update entity (home-assistant#106690) * add nextcloud update entity * don't init update entity on older nextcloud versions * ruff * pass skipUpdate to module * bump deps * bump requirements * Update homeassistant/components/nextcloud/update.py Co-authored-by: Michael <35783820+mib1185@users.noreply.github.com> * Update homeassistant/components/nextcloud/update.py Co-authored-by: Michael <35783820+mib1185@users.noreply.github.com> * bump requirements * Update homeassistant/components/nextcloud/update.py Co-authored-by: Michael <35783820+mib1185@users.noreply.github.com> * Update homeassistant/components/nextcloud/update.py Co-authored-by: Michael <35783820+mib1185@users.noreply.github.com> --------- Co-authored-by: Michael <35783820+mib1185@users.noreply.github.com> * Add DurationConverter (home-assistant#108865) * Add DurationConverter * Update withings snapshots * Add sensor test * Fix tests * Update snapshots after home-assistant#108902 was merged * Fix ZHA handling of power factor ElectricalMeasurement attribute sensor (home-assistant#107641) * Correct handling of power_factor ElectricalMeasurement attribute The Zigbee Cluster Library defines PowerFactor as an int8 with value supported from -100 to 100. Currently the zha sensor handler attempts to apply the ac_power_divisor and ac_power_multiplier formatters against the attribute value, the spec outlines that this should not be the case. The impact of the current code is that quirks not using the default values of 1 are multiplying/dividing power and power factor values prior to updating the cluster attribute. This results in either a non-conformant power_factor e.g. the value was multiplied by 10 so that an ac_power_divider of 10 could be used, or the power readings sacrificing a point of measurement for lower readings. Two quirks currently use this workaround: * ts0601_din_power.py * ts0601_rcbo.py * Update ZHA Metering formatter to perform None check on _div_mul_prefix To address feedback: home-assistant#107641 (comment) * _div_mul_prefix needs self reference * Simplify None check for _div_mul_prefix Co-authored-by: Joakim Plate <elupus@ecce.se> * Updates to formatting and CI test typing fix * Use ' | ' in place of Union * Add tests for power_factor sensor --------- Co-authored-by: Joakim Plate <elupus@ecce.se> * Bump regenmaschine to 2024.01.0 (home-assistant#109157) * Convert gather calls into TaskGroups (home-assistant#109010) * Fix "deprecated" typo in ZHA smartenergy comment (home-assistant#109173) * Fix "deprecated" typo in ZHA smartenergy comment * Fix in both places * Fix Ecovacs duration sensors (home-assistant#108868) * Store preferred border agent extended address for each thread dataset (home-assistant#109065) * Bump python-matter-server to 5.4.0 (home-assistant#109178) * Fix schema validation for product_id in picnic integration (home-assistant#109083) * Bumb python-homewizard-energy to 4.3.0 (home-assistant#109131) * Add alexa PowerController on enabled features for climate entities (home-assistant#109174) Depend alexa PowerController on enabled features for climate entities * Migrate Tuya integration to new sharing SDK (home-assistant#109155) * Scan QR code to log in And Migrate Tuya integration to new sharing SDK (home-assistant#104767) * Remove non-opt-in/out reporting * Improve setup, fix unload * Cleanup token listner, remove logging of sensitive data * Collection of fixes after extensive testing * Tests happy user config flow path * Test unhappy paths * Add reauth * Fix translation key * Prettier manifest * Ruff format * Cleanup of const * Process review comments * Adjust update token handling --------- Co-authored-by: melo <411787243@qq.com> * Add ZHA ZCL thermostat entities (home-assistant#106563) * Add OnOff trait for climate entities in google_assistant (home-assistant#109160) * Add generic typing for powerwall sensors (home-assistant#109008) * Add update platform to ZHA (bumps zigpy to 0.61.0) (home-assistant#107612) * stub out zha update entity * update matcher * updates based on assumptions / conversation * hook into current installed version * post rebase cleanup * incorporate zigpy changes * fix async_setup_entry * fix sw_version * make ota work with config diagnostic match * fix version format * sync up with latest Zigpy changes * fix name attribute * disable ota providers for tests * update device list * review comment * add current_file_version to Ota ZCL_INIT_ATTRS * updates to update and start tests * get installed version from restore data * better version handling * remove done todo notes * reorganize test * move image notify to cluster handler * add test for manual update check * firmware update success test * coverage * use zigpy defs * clean up after rebase * bump Zigpy * cleanup from review comments * fix busted F string * fix empty error * move inside check * guard zigbee network from bulk check for updates * Add additional entities for the Aqara E1 curtain motor to ZHA (home-assistant#108243) * aqara curtain motor opened by hand binary sensor add icon and translation key for identify button remove previous inversion entity add window covering type sensor and aqara curtain motor sensors add aqara curtain motor hook lock switch add aqara curtain motor attributes zcl_init_attrs add aqara curtain motor zcl_init_attrs translations * update translation string * review comments * use enum sensor after rebase * remove button change * Add icon and state translations for zwave_js sensors (home-assistant#109186) * Change the suggested energy units to kWh (home-assistant#109184) * Change the suggested energy units to kWh since the practical value is pretty large. * Fix unit tests * allow songcast source to be stopped and played (home-assistant#109180) * Ensure bluetooth auto recovery does not run in tests (home-assistant#109163) If time was moved forward too much the scanner would try to auto recover * Remove unused constants from QNAP (home-assistant#109152) * Bump aioelectricitymaps to 0.2.0 (home-assistant#109150) * Intellifire: fix incorrect name attribute in debug log when setting flame height (home-assistant#109168) * Add individual battery banks as devices (home-assistant#108339) * Add last seen sensor for zwave_js devices (home-assistant#107345) * Add log to show last received UniFi websocket message (home-assistant#109167) * Add Ecovacs button entities (home-assistant#109189) * Use constants in Picnic service functions (home-assistant#109170) Co-authored-by: Franck Nijhof <git@frenck.dev> * Add test case for binary sensors in ViCare (home-assistant#108769) Co-authored-by: Robert Resch <robert@resch.dev> * Add state_class to Kostal plenticore sensors (home-assistant#108096) * Add coordinator to ring integration (home-assistant#107088) * Add romy vacuum integration (home-assistant#93750) Co-authored-by: Erik Montnemery <erik@montnemery.com> Co-authored-by: Robert Resch <robert@resch.dev> Co-authored-by: Allen Porter <allen.porter@gmail.com> * Add session energy sensor for Tesla Wall Connector (home-assistant#102635) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * Minor fixes to A. O. Smith integration (home-assistant#107421) * Migrate QNAP to has entity name (home-assistant#107232) * Migrate QNAP to has entity name * Update homeassistant/components/qnap/strings.json Co-authored-by: disforw <github@benzona.net> * Apply suggestions from code review Co-authored-by: disforw <github@benzona.net> --------- Co-authored-by: disforw <github@benzona.net> * Add configflow to Proximity integration (home-assistant#103894) * add config flow * fix tests * adjust and fix tests * fix tests * config_zones as fixture * add config flow tests * use coordinator.async_config_entry_first_refresh * use entry.entry_id for hass.data * fix doc string * remove unused unit_of_measurement string key * don't store friendly_name, just use self.name * abort on matching entiry * break out legacy setup into seperate function * make tracked entites required * move _asnyc_setup_legacy to module level * use zone name as config entry title * add entity_used_in helper * check entry source if imported * create repair issue for removed tracked entities * separate state change from registry change event handling * migrate unique ids after tracked entity renamed * use full words for the variable names * use defaultdict * add test * remove unnecessary if not in check * use unique_id of tracked entity * use the entity registry entry id * Apply suggestions from code review Co-authored-by: Martin Hjelmare <marhje52@gmail.com> --------- Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * Use home/sleep preset in ViCare climate entity (home-assistant#105636) * use home/sleep preset * avoid setting reduced * Make google_assistant report_state test timezone aware (home-assistant#109200) * Apply late review comments for Comelit climate (home-assistant#109114) * Apply late review comments for Comelit climate * remove logging * Add Qnap icon translations (home-assistant#108484) * Add Qnap icon translations * Update homeassistant/components/qnap/icons.json Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> --------- Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * Code quality for Vodafone tests (home-assistant#109078) vodafone pylance fixes * Update Ecovacs config_flow to support self-hosted instances (home-assistant#108944) * Update Ecovacs config_flow to support self-hosted instances * Selfhosted should add their instance urls * Improve config flow * Improve and adapt to version bump * Add test for self-hosted * Make ruff happy * Update homeassistant/components/ecovacs/strings.json Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * Implement suggestions * Apply suggestions from code review Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * Implement suggestions * Remove , --------- Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * Make flexit bacnet switch more generic and prepare for more switches (home-assistant#109154) Make switch more generic and prepare for more switches * Add fuelcell gas consumption sensors to ViCare integration (home-assistant#105461) * add fuel cell gas consumption sensors * add total gas consumption sensors * add uom * Update strings.json * reorder * Revert "reorder" This reverts commit 0bcaa3b. * Revert "add uom" This reverts commit b3c0dc4. * Update sensor.py * Set entity category for QNAP sensors (home-assistant#109207) * Add Matter Websocket commands for node actions and diagnostics (home-assistant#109127) * bump python-matter-server to version 5.3.0 * Add all node related websocket services * remove open_commissioning_window service as it wasnt working anyways * use device id instead of node id * tests * add decorator to get node * add some tests for invalid device id * add test for unknown node * add explicit exception * adjust test * move exceptions * remove the additional config entry check for now to be picked up in follow up pR * Add Ecovacs number entities (home-assistant#109209) * Add Elvia integration (home-assistant#107405) * Add Traccar server integration (home-assistant#109002) * Add Traccar server integration * Add explination * Update homeassistant/components/traccar_server/coordinator.py Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * Add data_description --------- Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * Move tankerkoenig to new aiotankerkoenig package (home-assistant#108913) * Move tankerkoenig to new aiotankerkoenig package * Fix config flow coverage * Process code review suggestions * Process code review suggestions * Create issues for reauth flows (home-assistant#109105) * Fix Huisbaasje negative periodic gas readings (home-assistant#103457) (home-assistant#108090) * Support alternative modelid for LIDL doorbell in deCONZ device triggers (home-assistant#107937) Add support alternative modelid for LIDL doorbell * Add Ecovacs switch entities (home-assistant#109216) * Improve enabling of Google local fulfillment (home-assistant#109192) * Improve enabling of Google local fulfillment * Add test * Improve test coverage * Modify climate turn_on/off backwards compatibility check (home-assistant#109195) * Modify climate turn_on/off backwards compatibility check * Fix logger message * Comments * Fix demo * devolo * ecobee * Some more * Fix missing feature flag * some more * and some more * Remove demo change * Add back demo change * Fix demo * Update comments * Add readable state for tesla wall connector (home-assistant#107909) * Add readable state for tesla wall connector * Add test * Display raw sensor by default * Use none instead of unknown * Remove old state from tests * Rename raw state to status code * Test unknown * Update homeassistant/components/tesla_wall_connector/strings.json Co-authored-by: Franck Nijhof <git@frenck.dev> --------- Co-authored-by: Franck Nijhof <git@frenck.dev> * Rename Traccar to Traccar Client (home-assistant#109217) * Use EnumSensor instead of custom formatter() in ZHA Sensor entities (home-assistant#109218) use EnumSensor for SonofPresenceSensorIlluminationStatus and AqaraPetFeederLastFeedingSource * Add ZHA support for Bosch Twinguard and siren install QR codes (home-assistant#107460) * Enable Bosch Outdoor Siren and Bosch Twinguard QR Codes These devices contain inside their QR code device specific link keys instead of installation codes. Normally, the link key is generated from the installation code, but in this case we can directly pass the provided link key from QR code to zigpy application controller. * Replace ZHA deprecated permit_with_key by permit_with_link_key Convert installation code directly to link key * Update tests * formatting * Add brands definition for Traccar (home-assistant#109219) * Import Traccar YAML configuration to Traccar Server (home-assistant#109226) * Import Traccar YAML configuration to Traccar Server * Remove import * Add config flow to GPSD (home-assistant#106196) * Add qr code selector (home-assistant#109214) * Fix ring chimes data update (home-assistant#109220) * Fix bug with chimes data update * Trigger update in test with time change * Fix test to use freezer * Make test less fragile * Update frontend to 20240131.0 (home-assistant#109231) * Add test for integration migrated in climate (home-assistant#109224) * Suppress log warnings when a sensor group has non numeric members (home-assistant#102828) * Add reauth flow to kitchen sink (home-assistant#109202) * Sort script actions (home-assistant#108247) * Add translations to GPSd (home-assistant#108600) * Add config flow to GPSD * Add translations to GPSd * Add device class * Apply feedback for unique_id and translation_key * Bump govee-ble to 0.31.0 (home-assistant#109235) * Bump ring_doorbell to 0.8.6 (home-assistant#109199) * Fix time to arrival to timestamp in Tessie (home-assistant#109172) * Fix time to arrival * Update snapshot * Freeze time for snapshot * Fix docstring * Add available_fn * Update snapshot * Dont use variance for full charge * Remove unrelated changes * Revert snapshot * Rename hours_to_datetime * Bump version to 2024.3.0dev0 (home-assistant#109238) * Fix kitchen sink tests (home-assistant#109243) * Bump opower to 0.3.0 (home-assistant#109248) Co-authored-by: Dan Swartz <3066652+swartzd@users.noreply.github.com> * Make zwave_js last seen sensor enabled by default (home-assistant#109191) * Make zwave_js last seen sensor enabled by default * Add test * Fix test * improve tests * Pass verify_ssl to created session in Omada (home-assistant#109212) * Pass verify_ssl to created session in Omada * Fix tests * Fix tests * Only decode msg topic once when handling mqtt payloads (home-assistant#109258) * Fix ZHA update entity not updating installed version (home-assistant#109260) * Bump sigstore/cosign-installer from 3.3.0 to 3.4.0 (home-assistant#109278) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix dalkin climate warnings (home-assistant#109279) * Fix app name sorting in apple_tv (home-assistant#109274) * Restore support for packages being installed from urls with fragments (home-assistant#109267) * Fix two icon translations for La Marzocco (home-assistant#109284) * Add icon translations to GPSd (home-assistant#108602) * bugfix: name missing in getLogger (home-assistant#109282) * Apply review comments on proximity (home-assistant#109249) use a named tuple as TrackedEntityDescriptor * Fix Xiaomi-ble automations for multiple button devices (home-assistant#109251) * Update rokuecp to 0.19 (home-assistant#109100) * Remove quality scale platinum from daikin integration (home-assistant#109292) * Fix device class repairs issues UOM placeholders in Group (home-assistant#109294) * Bump hass-nabucasa from 0.75.1 to 0.76.0 (home-assistant#109296) * Address late review of Tankerkoenig package move (home-assistant#109277) * Remove deprecation warnings for zwave_js climate TURN_ON/TURN_OFF features (home-assistant#109242) * Bump airthings-ble to 0.6.1 (home-assistant#109302) Bump airthings-ble * Update ruff to 0.1.15 (home-assistant#109303) * Don't log warning for core integrations on new feature flags in Climate (home-assistant#109250) * Don't log for core integration on Climate new feature flags * Add test * Fix test * Bump pytedee_async to 0.2.13 (home-assistant#109307) bump * Do not use a battery device class for Shelly analog input sensor (home-assistant#109311) Co-authored-by: Maciej Bieniek <478555+bieniu@users.noreply.github.com> * Verify Ecovacs mqtt config (home-assistant#109306) * Add climate on/off feature to Tessie (home-assistant#109239) * Add climate turn on/off feature to Teslemetry (home-assistant#109241) * Fix race in loading service descriptions (home-assistant#109316) * Move default response out of sentence trigger registration and into agent (home-assistant#109317) * Move default response out of trigger and into agent * Add test * Remove battery charge sensor from powerwall (home-assistant#109271) * Add translations for zwave_js entities and services (home-assistant#109188) * Migrate to new intent error response keys (home-assistant#109269) * Add connect octoprint printer service (home-assistant#99899) * Add connect octoprint printer service * Review changes * String updates * Swap exception type * Fix custom attribute lookup in Traccar Server (home-assistant#109331) * Update Home Assistant base image to 2024.02.0 (home-assistant#109329) * Add device class to tesla wall connector session energy (home-assistant#109333) * Fix stale camera error message in img_util (home-assistant#109325) * Add TURN_ON/OFF ClimateEntityFeature for Matter (home-assistant#108974) * Add TURN_ON/OFF ClimateEntityFeature for Matter * Adjust matter * Missing template helper translation keys (home-assistant#109347) * Reduce lock contention when all icons are already cached (home-assistant#109352) * Load json file as binary instead of decoding to string (home-assistant#109351) * Add sensibo migrated ClimateEntityFeatures (home-assistant#109340) Adds sensibo migrated ClimateEntityFeatures * Avoid de/recode of bytes to string to bytes when writing json files (home-assistant#109348) * Add Adax migrated ClimateEntityFeatures (home-assistant#109341) * Add Duquesne Light virtual integration supported by opower (home-assistant#109272) Co-authored-by: Dan Swartz <3066652+swartzd@users.noreply.github.com> * Add migrated ClimateEntityFeature for Nibe Heat Pump (home-assistant#109140) * Add TURN_ON/OFF ClimateEntityFeature for Modbus (home-assistant#109133) * Ensure the purge entities service cleans up the states_meta table (home-assistant#109344) * Add migrated ClimateEntityFeature for Atag (home-assistant#108961) * Add migrated ClimateEntityFeature for SwitchBot Cloud (home-assistant#109136) * Add TURN_ON/OFF ClimateEntityFeature for Fibaro (home-assistant#108963) * Use send_json_auto_id in recorder tests (home-assistant#109355) * Use a mocked API client in Traccar Server tests (home-assistant#109358) * Correct modbus commit validation, too strict on integers (home-assistant#109338) * Add TURN_ON/OFF ClimateEntityFeature for KNX (home-assistant#109138) * Improve color mode handling in MockLight (home-assistant#109298) * Hide unsupported devices in Airthings BLE config flow (home-assistant#107648) * Update cryptography to 42.0.2 (home-assistant#109359) * Follow up swiss_public_transport migration fix of unique ids (home-assistant#107873) improve migration fix of unique ids - follow up to home-assistant#107087 * Bump deebot_client to 5.1.0 (home-assistant#109360) * Disable less interesting sensors by default in ViCare integration (home-assistant#109014) * Update sentry-sdk to 1.40.0 (home-assistant#109363) * Remove suggested area from Verisure (home-assistant#109364) * Use translation placeholders in 1-Wire (home-assistant#109120) * Change device class of Auto Seat Heater sensors in Tessie (home-assistant#109240) * Centralize validation for modbus config (home-assistant#108906) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * Add Charging sensor to Tessie (home-assistant#108205) * Specify end_time when importing Elvia data to deal with drift (home-assistant#109361) * Add entity name translations to Tibber (home-assistant#108797) * Improve Ecovacs naming (home-assistant#109372) * Add entity description to GPSD (home-assistant#109320) * Use send_json_auto_id in conversation tests (home-assistant#109354) * Update frontend to 20240202.0 (home-assistant#109388) * Add independent session in honeywell (home-assistant#108435) --------- Co-authored-by: Robert Resch <robert@resch.dev> Co-authored-by: Paul Bottein <paul.bottein@gmail.com> Co-authored-by: Brett Adams <Bre77@users.noreply.github.com> Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Co-authored-by: J. Nick Koston <nick@koston.org> Co-authored-by: Kristof Mariën <krmarien@gmail.com> Co-authored-by: Franck Nijhof <git@frenck.dev> Co-authored-by: Marcel van der Veldt <m.vanderveldt@outlook.com> Co-authored-by: Cody C <50791984+codyc1515@users.noreply.github.com> Co-authored-by: puddly <32534428+puddly@users.noreply.github.com> Co-authored-by: Simone Chemelli <simone.chemelli@gmail.com> Co-authored-by: Raman Gupta <7243222+raman325@users.noreply.github.com> Co-authored-by: Allen Porter <allen@thebends.org> Co-authored-by: Martin Hjelmare <marhje52@gmail.com> Co-authored-by: peebles <aqpeeb@gmail.com> Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> Co-authored-by: Michael Hansen <mike@rhasspy.org> Co-authored-by: Christophe Gagnier <Moustachauve@users.noreply.github.com> Co-authored-by: Franck Nijhof <frenck@frenck.nl> Co-authored-by: cbrherms <adam.d.shearman@gmail.com> Co-authored-by: David F. Mulcahey <david.mulcahey@me.com> Co-authored-by: Mohamed <10786768+xMohamd@users.noreply.github.com> Co-authored-by: Joakim Plate <elupus@ecce.se> Co-authored-by: G Johansson <goran.johansson@shiftit.se> Co-authored-by: vexofp <vexofp@gmail.com> Co-authored-by: jmwaldrip <jmwaldrip@gmail.com> Co-authored-by: Florian Kisser <github@kssr.net> Co-authored-by: Matrix <justin@yosmart.com> Co-authored-by: Michal Ziemski <michal@terrestryal.com> Co-authored-by: Ståle Storø Hauknes <stale.semb@airthings.com> Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com> Co-authored-by: Yuxin Wang <yuxinwang.dev@gmail.com> Co-authored-by: Christopher Fenner <9592452+CFenner@users.noreply.github.com> Co-authored-by: Erik Montnemery <erik@montnemery.com> Co-authored-by: Ernst Klamer <e.klamer@gmail.com> Co-authored-by: Jack <46714706+jeverley@users.noreply.github.com> Co-authored-by: karwosts <32912880+karwosts@users.noreply.github.com> Co-authored-by: David Mulcahey <david.mulcahey@icloud.com> Co-authored-by: escoand <escoand@users.noreply.github.com> Co-authored-by: Michael <35783820+mib1185@users.noreply.github.com> Co-authored-by: Josh Pettersen <12600312+bubonicbob@users.noreply.github.com> Co-authored-by: Noah Groß <me@codesalat.dev> Co-authored-by: Duco Sebel <74970928+DCSBL@users.noreply.github.com> Co-authored-by: melo <411787243@qq.com> Co-authored-by: Caius-Bonus <123886836+Caius-Bonus@users.noreply.github.com> Co-authored-by: Barry Williams <barry@jwilliams.uk> Co-authored-by: Jan Rieger <jrieger@users.noreply.github.com> Co-authored-by: Jan-Philipp Benecke <jan-philipp@bnck.me> Co-authored-by: julienfreche <julien@bedrocksystems.com> Co-authored-by: Robert Svensson <Kane610@users.noreply.github.com> Co-authored-by: stegm <stegm@users.noreply.github.com> Co-authored-by: Steven B <51370195+sdb9696@users.noreply.github.com> Co-authored-by: Manuel Dipolt <manuel@linux-home.at> Co-authored-by: Allen Porter <allen.porter@gmail.com> Co-authored-by: Mandar Patil <mandarons@pm.me> Co-authored-by: Brandon Rothweiler <2292715+bdr99@users.noreply.github.com> Co-authored-by: disforw <github@benzona.net> Co-authored-by: Jonas Fors Lellky <lellky@gmail.com> Co-authored-by: Joakim Sørensen <ludeeus@ludeeus.dev> Co-authored-by: Jeroen van Ingen Schenau <jeroen@zijndomein.nl> Co-authored-by: Paul Strawder <paulidstein@gmail.com> Co-authored-by: Bram Kragten <mail@bramkragten.nl> Co-authored-by: Tucker Kern <mill1000@users.noreply.github.com> Co-authored-by: Dan <swartzd@users.noreply.github.com> Co-authored-by: Dan Swartz <3066652+swartzd@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josef Zweck <24647999+zweckj@users.noreply.github.com> Co-authored-by: Luis Andrade <llluis@gmail.com> Co-authored-by: Chris Talkington <chris@talkingtontech.com> Co-authored-by: Maciej Bieniek <bieniu@users.noreply.github.com> Co-authored-by: Maciej Bieniek <478555+bieniu@users.noreply.github.com> Co-authored-by: Ryan Fleming <rfleming71@users.noreply.github.com> Co-authored-by: jan iversen <jancasacondor@gmail.com> Co-authored-by: Cyrill Raccaud <miaucl@users.noreply.github.com> Co-authored-by: mkmer <m_kasper@sbcglobal.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Commit 3cc5ffa solved a number of problems and slimlined the validation, but is too strict for integers.
When "precision:" is configured, the int received must be converted to a float and treated with the defined decimals.
This PR repairs commit 3cc5ffa.
Type of change
Additional information
fixes Modbus does not respect precision anymore #109310
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: