Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tradfri asyncio.wait #99730

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Sep 6, 2023

Proposed change

Releated to #99726

Starting with Python 3.11.0 asyncio.wait raises a TypeError if a coroutine is passed directly to asyncio.wait.
https://github.com/python/cpython/blob/v3.11.0/Lib/asyncio/tasks.py#L414-L415

At first it was slightly surprising to me that this wasn't caught be our test suite. However, looking the coverage for tradfri/config_flow.py is only ~80%. It wasn't really changed since the initial commit years ago #16665.
https://app.codecov.io/gh/home-assistant/core/commit/b815ea1332667e10c5af3c4387bcfa41961d590f/blob/homeassistant/components/tradfri/config_flow.py

Looking at the code section in question, I wonder if it's even necessary / should be there. There are also no open issues for this particular bug.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco added this to the 2023.9.0 milestone Sep 6, 2023
@bdraco
Copy link
Member

bdraco commented Sep 6, 2023

Can be bumped to 2023.9.1 as this is not a major problem and has existed for a while

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today we'd update the config entry and abort.

@MartinHjelmare MartinHjelmare merged commit d8035dd into home-assistant:dev Sep 6, 2023
@cdce8p cdce8p deleted the fix-tradfri branch September 6, 2023 14:58
@edenhaus edenhaus modified the milestones: 2023.9.0, 2023.9.1 Sep 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants