Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Releated to #99726
Starting with Python 3.11.0
asyncio.wait
raises aTypeError
if a coroutine is passed directly toasyncio.wait
.https://github.com/python/cpython/blob/v3.11.0/Lib/asyncio/tasks.py#L414-L415
At first it was slightly surprising to me that this wasn't caught be our test suite. However, looking the coverage for
tradfri/config_flow.py
is only ~80%. It wasn't really changed since the initial commit years ago #16665.https://app.codecov.io/gh/home-assistant/core/commit/b815ea1332667e10c5af3c4387bcfa41961d590f/blob/homeassistant/components/tradfri/config_flow.py
Looking at the code section in question, I wonder if it's even necessary / should be there. There are also no open issues for this particular bug.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: