Release/2023 05 02 #612
Merged
Release/2023 05 02 #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for housing-sanjoseca-gov ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for hba-public-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hmmm 🍍 anytime I run this locally and try to apply to a listing, I get a Unhandled Runtime Error and see the following in the terminal (occurred for multiple listings) |
|
@ColinBuyck I am unable to reproduce that. At what point do you get the error? Is it right when you click the confirm button? It looks like it fails on an options call which is weird |
* feat: upgrade nextjs to 13 * fix: attempt to get cypress test working
* feat: removing sensative info from leasing agent * fix: adding swagger changes * fix: updates for tests
Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: updates around cookies * fix: creating new migration for token -> code
…oom-housing#3408) * fix: pass proper value to to_tsquery function * fix: search applications using ILIKE * fix: change where to orWhere * feat: add application search by confirmation code
* feat: updates proxy to support access control allow list * fix: remove downstream access-control-allow-origin * fix: update readme for m1 * fix: move purge call to the backend * fix: test fix and add await * fix: moving cache purge to helper --------- Co-authored-by: Morgan Ludtke <ludtkemorgan@gmail.com> Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com>
ludtkemorgan
force-pushed
the
release/2023-05-02
branch
from
28e2e3c
to
9157054
Compare
|
Is this ready for another set of eyes after the bash? |
|
@emilyjablonski, yes this can be reviewed. This bug is preventing us from releasing bloom-housing#3430. But the code can be looked at and I would like to get this merged, we just can't release |
* fix: functional frontend * fix: hooks and service updates * fix: hitting service file * fix: wip config work * fix: wip config 2 * fix: completed query updates * fix: complete column naming and basic formatting * fix: clean up formatting * fix: wip testing debugging * fix: functional unit tests * fix: cypress tests + formatting * fix: unadded test changes * fix: internal csv testing * fix: exporter test fix * fix: more detailed csv checks * fix: testing + formatting tweaks * fix: exporter testing improvements * fix: updates per pr feedback * fix: match config pattern * fix: add close status option * fix: reset netlify testing * fix: final cleanup * fix: rent type formatting * fix: remove console log
* feat: adding knownError flag
YazeedLoonat
approved these changes
May 18, 2023
| @@ -60,7 +61,12 @@ const ListingIntro = (props: ListingIntroProps) => { | |||
| keyPrefix={"jurisdictions"} | |||
| options={jurisdictionOptions} | |||
| inputProps={{ | |||
| onChange: () => clearErrors("jurisdiction"), | |||
| onChange: () => { | |||
| console.log("jurisdiction change") | |||
There was a problem hiding this comment.
may want to pull this console log out
YazeedLoonat
approved these changes
May 18, 2023
* fix: partners highlight field on backend error * fix: community type and disableUnitsAccordion fix * fix: unit type fix for partial units * fix: review comment addressed * fix: phone number fix
ludtkemorgan
force-pushed
the
release/2023-05-02
branch
from
28f2870
to
8dd892f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls the following changes over from core: