Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uptake latest uic Modal, ActionBlock, FormCard breaking changes #3358

Merged
merged 8 commits into from
Mar 21, 2023

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Mar 15, 2023

Uptakes the latest breaking changes in the Modal, ActionBlock, and FormCard component from UIC which renames the scrollable prop (Modal UIC PR) (ActionBlock UIC PR) (FormCard PR)

The data-test-id changes are from a change to the test ids in the SiteHeader updates

@netlify
Copy link

netlify bot commented Mar 15, 2023

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit c63f0e8
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/6419f1fa3e878300071055bc
😎 Deploy Preview https://deploy-preview-3358--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@emilyjablonski emilyjablonski added the 2 reviews needed Requires 2 more review before ready to merge label Mar 15, 2023
@emilyjablonski emilyjablonski added wip This PR is not ready for review, do not review it's a “Work In Progress” and removed 2 reviews needed Requires 2 more review before ready to merge labels Mar 15, 2023
@emilyjablonski emilyjablonski changed the title fix: uptake latest uic modal breaking changes fix: uptake latest uic Modal, ActionBlock breaking changes Mar 15, 2023
@emilyjablonski emilyjablonski added 2 reviews needed Requires 2 more review before ready to merge and removed wip This PR is not ready for review, do not review it's a “Work In Progress” labels Mar 17, 2023
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👾

@ludtkemorgan ludtkemorgan added 1 review needed Requires 1 more review before ready to merge and removed 2 reviews needed Requires 2 more review before ready to merge labels Mar 17, 2023
@emilyjablonski emilyjablonski changed the title fix: uptake latest uic Modal, ActionBlock breaking changes fix: uptake latest uic Modal, ActionBlock, FormCard breaking changes Mar 20, 2023
Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍎 🍽️ 🐭 🐭 🐭 🍽️ 🧀

@ColinBuyck ColinBuyck added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Mar 21, 2023
@emilyjablonski emilyjablonski merged commit 5befda9 into main Mar 21, 2023
@emilyjablonski emilyjablonski deleted the uptake-latest-uic branch March 21, 2023 23:25
ludtkemorgan added a commit to housingbayarea/bloom that referenced this pull request Mar 29, 2023
ludtkemorgan added a commit to housingbayarea/bloom that referenced this pull request Apr 3, 2023
* test: add unit tests on the ListingView component (bloom-housing#3344)

* test: add unit tests on the ListingView component

* chore: make date variables consistent

* test: remove afterEach line

* chore(deps): bump class-validator from 0.12.2 to 0.14.0 (bloom-housing#3257)

Bumps [class-validator](https://github.com/typestack/class-validator) from 0.12.2 to 0.14.0.
- [Release notes](https://github.com/typestack/class-validator/releases)
- [Changelog](https://github.com/typestack/class-validator/blob/develop/CHANGELOG.md)
- [Commits](typestack/class-validator@v0.12.2...v0.14.0)

---
updated-dependencies:
- dependency-name: class-validator
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: upgrade to node 18 and next 12 (bloom-housing#3343)

* feat: upgrade to node 19 and next 12

* fix: add netlify plugin

* fix: add netlify plugin partners

* fix: remove netlify plugins

* fix: add netlify plugin to toml

* Revert "fix: remove netlify plugins"

This reverts commit 840b4a1.

* fix: switch to node 16

* fix: update all places referencing node

* Revert "fix: update all places referencing node"

This reverts commit 9f13a5a.

* Revert "fix: switch to node 16"

This reverts commit 8acbfbe.

* fix: re-installed with 18

* feat: add user csv export (bloom-housing#3341)

* fix: uptake latest uic Modal, ActionBlock, FormCard breaking changes (bloom-housing#3358)

* feat: add shared bathroom option  (bloom-housing#3362)

* fix: add imports to calm tests

* Revert "fix: uptake latest uic Modal, ActionBlock, FormCard breaking changes (bloom-housing#3358)"

This reverts commit b1153f0.

* fix: user export fixes (bloom-housing#3371)

* fix: user export fixes

* fix: update error message alert

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Liann Sun <lianns@google.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ludtkemorgan added a commit to housingbayarea/bloom that referenced this pull request May 18, 2023
* fix: uptake latest uic Modal, ActionBlock, FormCard breaking changes (bloom-housing#3358)

* feat: upgrade react to 18 (bloom-housing#3360)

* feat: upgrade nextjs to 13 (bloom-housing#3375)

* feat: upgrade nextjs to 13

* fix: attempt to get cypress test working

* feat: changing auth over to cookies (bloom-housing#3357)

* fix: resolves issues around markedAsDuplicate (bloom-housing#3373)

* fix: react type errors (bloom-housing#3382)

* refactor: add cloudinary fxn to partners (bloom-housing#3393)

* refactor: uptake seeds FormErrorMessage (bloom-housing#3369)

* fix: add startDate to open house submit event (bloom-housing#3399)

* fix: add three new fields to base view (bloom-housing#3406)

* feat: removing sensative info from leasing agent (bloom-housing#3409)

* feat: removing sensative info from leasing agent

* fix: adding swagger changes

* fix: updates for tests

* chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295)

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: updates around cookies (bloom-housing#3405)

* fix: updates around cookies

* fix: creating new migration for token -> code

* fix: Searching on the applications table causes the page to crash (bloom-housing#3408)

* fix: pass proper value to to_tsquery function

* fix: search applications using ILIKE

* fix: change where to orWhere

* feat: add application search by confirmation code

* updates proxy to support access control allow list (bloom-housing#3407)

* feat: updates proxy to support access control allow list

* fix: remove downstream access-control-allow-origin

* fix: update readme for m1

* fix: move purge call to the backend

* fix: test fix and add await

* fix: moving cache purge to helper

---------

Co-authored-by: Morgan Ludtke <ludtkemorgan@gmail.com>
Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com>

* fix: escape quote in translation update

* fix: add translation for 64 characters error (bloom-housing#3423)

* fix: downgrade version of nest axios (bloom-housing#3419)

* fix: now removes criteria file if a url is input (bloom-housing#3421)

* fix: remove check in test not applicable for hba

* fix: update ui-c to latest version (bloom-housing#3420)

* fix: update application test

* feat: 3291/listing export take 2 (bloom-housing#3424)

* fix: functional frontend

* fix: hooks and service updates

* fix: hitting service file

* fix: wip config work

* fix: wip config 2

* fix: completed query updates

* fix: complete column naming and basic formatting

* fix: clean up formatting

* fix: wip testing debugging

* fix: functional unit tests

* fix: cypress tests + formatting

* fix: unadded test changes

* fix: internal csv testing

* fix: exporter test fix

* fix: more detailed csv checks

* fix: testing + formatting tweaks

* fix: exporter testing improvements

* fix: updates per pr feedback

* fix: match config pattern

* fix: add close status option

* fix: reset netlify testing

* fix: final cleanup

* fix: rent type formatting

* fix: remove console log

* fix: missing state data (bloom-housing#3450)

* feat: adding knownError flag

* feat: adding knownError flag

* fix: partners highlight field on backend error (bloom-housing#3448)

* fix: partners highlight field on backend error

* fix: community type and disableUnitsAccordion fix

* fix: unit type fix for partial units

* fix: review comment addressed

* fix: phone number fix

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sean Albert <smabert@gmail.com>
Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants