-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3291/listing export take 2 #3424
Conversation
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few notes:
- In the status column I'm seeing "Public" or empty, could be intentional but might have assumed there would be different text in the draft state
Are postmarks considered?
isn't populating even if there is data
@emilyjablonski @ludtkemorgan Thank you both for the review! I've fixed the postmark issue and made the decision to shift "Are postmarks considered?" to just "Postmark" and show either the date or nothing. This mirrors the pattern used in Detroit. Do you have any concerns with this change @sarahlazarich? As for the empty status, I realized I forgot to cover the closed state and that should be covered now! Good catch For the jurisdictional admin piece, I made a bigger change to address that the story says "As a jurisdictional admin OR an admin in partners portal". The export should now function for both roles and will only show the permissioned listings for the respective user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍭
no concerns with that change @ColinBuyck ! |
* fix: functional frontend * fix: hooks and service updates * fix: hitting service file * fix: wip config work * fix: wip config 2 * fix: completed query updates * fix: complete column naming and basic formatting * fix: clean up formatting * fix: wip testing debugging * fix: functional unit tests * fix: cypress tests + formatting * fix: unadded test changes * fix: internal csv testing * fix: exporter test fix * fix: more detailed csv checks * fix: testing + formatting tweaks * fix: exporter testing improvements * fix: updates per pr feedback * fix: match config pattern * fix: add close status option * fix: reset netlify testing * fix: final cleanup * fix: rent type formatting * fix: remove console log
* fix: uptake latest uic Modal, ActionBlock, FormCard breaking changes (bloom-housing#3358) * feat: upgrade react to 18 (bloom-housing#3360) * feat: upgrade nextjs to 13 (bloom-housing#3375) * feat: upgrade nextjs to 13 * fix: attempt to get cypress test working * feat: changing auth over to cookies (bloom-housing#3357) * fix: resolves issues around markedAsDuplicate (bloom-housing#3373) * fix: react type errors (bloom-housing#3382) * refactor: add cloudinary fxn to partners (bloom-housing#3393) * refactor: uptake seeds FormErrorMessage (bloom-housing#3369) * fix: add startDate to open house submit event (bloom-housing#3399) * fix: add three new fields to base view (bloom-housing#3406) * feat: removing sensative info from leasing agent (bloom-housing#3409) * feat: removing sensative info from leasing agent * fix: adding swagger changes * fix: updates for tests * chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295) Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updates around cookies (bloom-housing#3405) * fix: updates around cookies * fix: creating new migration for token -> code * fix: Searching on the applications table causes the page to crash (bloom-housing#3408) * fix: pass proper value to to_tsquery function * fix: search applications using ILIKE * fix: change where to orWhere * feat: add application search by confirmation code * updates proxy to support access control allow list (bloom-housing#3407) * feat: updates proxy to support access control allow list * fix: remove downstream access-control-allow-origin * fix: update readme for m1 * fix: move purge call to the backend * fix: test fix and add await * fix: moving cache purge to helper --------- Co-authored-by: Morgan Ludtke <ludtkemorgan@gmail.com> Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com> * fix: escape quote in translation update * fix: add translation for 64 characters error (bloom-housing#3423) * fix: downgrade version of nest axios (bloom-housing#3419) * fix: now removes criteria file if a url is input (bloom-housing#3421) * fix: remove check in test not applicable for hba * fix: update ui-c to latest version (bloom-housing#3420) * fix: update application test * feat: 3291/listing export take 2 (bloom-housing#3424) * fix: functional frontend * fix: hooks and service updates * fix: hitting service file * fix: wip config work * fix: wip config 2 * fix: completed query updates * fix: complete column naming and basic formatting * fix: clean up formatting * fix: wip testing debugging * fix: functional unit tests * fix: cypress tests + formatting * fix: unadded test changes * fix: internal csv testing * fix: exporter test fix * fix: more detailed csv checks * fix: testing + formatting tweaks * fix: exporter testing improvements * fix: updates per pr feedback * fix: match config pattern * fix: add close status option * fix: reset netlify testing * fix: final cleanup * fix: rent type formatting * fix: remove console log * fix: missing state data (bloom-housing#3450) * feat: adding knownError flag * feat: adding knownError flag * fix: partners highlight field on backend error (bloom-housing#3448) * fix: partners highlight field on backend error * fix: community type and disableUnitsAccordion fix * fix: unit type fix for partial units * fix: review comment addressed * fix: phone number fix --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com>
* feat: 3291/listing export take 2 (bloom-housing#3424) * fix: functional frontend * fix: hooks and service updates * fix: hitting service file * fix: wip config work * fix: wip config 2 * fix: completed query updates * fix: complete column naming and basic formatting * fix: clean up formatting * fix: wip testing debugging * fix: functional unit tests * fix: cypress tests + formatting * fix: unadded test changes * fix: internal csv testing * fix: exporter test fix * fix: more detailed csv checks * fix: testing + formatting tweaks * fix: exporter testing improvements * fix: updates per pr feedback * fix: match config pattern * fix: add close status option * fix: reset netlify testing * fix: final cleanup * fix: rent type formatting * fix: remove console log * fix: missing state data (bloom-housing#3450) * feat: adding knownError flag * feat: adding knownError flag * fix: partners highlight field on backend error (bloom-housing#3448) * fix: partners highlight field on backend error * fix: community type and disableUnitsAccordion fix * fix: unit type fix for partial units * fix: review comment addressed * fix: phone number fix * fix: stop transforming null to zero (bloom-housing#3453) * fix: stop transforming null to zero * fix: other fields defaulting to zero * fix: public multiple photos from detroit (bloom-housing#3390) * feat: add multiple photos * feat: add tests * feat: add images to seeds * fix: return array when no image * fix: shared helpers photos tests * fix: add class with variables to parent element * fix: make actions inside content section optional on desktop * fix: pass modalCloseInContent prop to listing view's ImageCard * fix: remove redundant image-card class * chore: upgrade ui-c * fix: remove redundant order column * fix: change font for drawer title * fix: remove default images value when editing --------- Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com> Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com> Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com> Co-authored-by: Chris Casto <chriscasto@google.com>
Pull Request Template
Issue Overview
This PR addresses #3291
Description
This PR adds the listings export functionality along with associated tests! Column information here: https://docs.google.com/spreadsheets/d/1iMhybYs0RSdW940e402oI8xsqot8BlAYHaVTXaORIeA/edit#gid=670984196
How Can This Be Tested/Reviewed?
This can be tested by clicking the export to csv button on the partners side and verifying that the listing data is displayed correctly. Additionally, create your own listing to test cases that may not be present in our seed.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.