This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Fixes slash commands when using internal webserver #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest changes of Slack removed the concept of a bot from things like slash command. Botkit was still assuming that slack will send the
botkey in the webhook payload which is not the case.This is a simple fix that will remove the requirement for that information to be present for slash command, outgoing webhooks and interactive messages. The
handleEventsAPImethod will actually try to use that data so I still included it for that case but fail if we don't find it in the payload.It was a blocker for us at message.io so we fixed and tested it in our own fork.
Should solve #590 (comment)