Cannot read property 'user_id' when dealing with Slack Apps. #590

kevinwritescode · 2017-01-10T06:33:01Z

When attempting to configure a private Slack App, I'm running into issues with team.bot.user_id being undefined? Is this a configuration issue with Slack Apps? The team object I get back in that area of code looks like this:

{
  "id": "UNIQID1",
  "createdBy": "UNIQID2",
  "url": "https://COMPANY.slack.com/",
  "name": "COMPANY"
}

I've pasted the error logs below.

TypeError: Cannot read property 'user_id' of undefined
    at /Users/knuut/slack-bot/node_modules/botkit/lib/SlackBot.js:177:33
    at Object.get (/Users/knuut/slack-bot/node_modules/botkit/lib/CoreBot.js:822:17)
    at Object.Slackbot.slack_botkit.findTeamById (/Users/knuut/slack-bot/node_modules/botkit/lib/SlackBot.js:300:36)
    at Object.Slackbot.slack_botkit.handleWebhookPayload (/Users/knuut/slack-bot/node_modules/botkit/lib/SlackBot.js:158:22)
    at /Users/knuut/slack-bot/node_modules/botkit/lib/SlackBot.js:137:26
    at Layer.handle [as handle_request] (/Users/knuut/slack-bot/node_modules/express/lib/router/layer.js:95:5)
    at next (/Users/knuut/slack-bot/node_modules/express/lib/router/route.js:131:13)
    at Route.dispatch (/Users/knuut/slack-bot/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/Users/knuut/slack-bot/node_modules/express/lib/router/layer.js:95:5)
    at /Users/knuut/slack-bot/node_modules/express/lib/router/index.js:277:22

I've also added the basic code used for testing.

const Botkit = require('botkit');

const controller = Botkit.slackbot({
  debug: true,
});

controller.configureSlackApp({
  clientId: process.env.CLIENT_ID,
  clientSecret: process.env.CLIENT_SECRET,
  scopes: ['incoming-webhook','team:read','users:read','channels:read','im:read','im:write','groups:read','emoji:read','chat:write:bot'],
});

controller.setupWebserver(process.env.PORT, (err, webserver) => {
  controller.createWebhookEndpoints(webserver);
  controller.createOauthEndpoints(webserver, (err2, req, res) => {
    if (err2) {
      res.status(500).send(`ERROR: ${err2}`);
    } else {
      res.send('Success!');
    }
  });
});

controller.on('slash_command', (bot, message) => {
  // check message.command
  // and maybe message.text...
  // use EITHER replyPrivate or replyPublic...
  bot.replyPrivate(message, `This is a private reply to the ${message.command} slash command!`);

  // and then continue to use replyPublicDelayed or replyPrivateDelayed
  bot.replyPublicDelayed(message, `This is a public reply to the ${message.command} slash command!`);

  bot.replyPrivateDelayed(message, ':dash:');
});

The text was updated successfully, but these errors were encountered:

kevinwritescode · 2017-01-10T06:42:34Z

It looks like it may be a configuration issue after all. I was able to get it to work once I also allowed "bot" during the oauth "Slack Button" creation, but I wasn't using a bot for anything in my scripts, just slash commands.

I'm not sure if there is any advise on how to set it up if you don't need a bot? Maybe I'm configuring the code improperly to handle a no bot situation.

ethan-sonza · 2017-02-09T05:58:17Z

Had the same issue. After allowing a bot, I'm getting the error:

TypeError: Cannot read property 'replace' of undefined
    at Object.<anonymous> (/home/ethan/node_projects/tripkada-slack/node_modules/botkit/lib/SlackBot.js:648:84)
    at Object.Botkit.botkit.trigger (/home/ethan/node_projects/tripkada-slack/node_modules/botkit/lib/CoreBot.js:986:49)
    at /home/ethan/node_projects/tripkada-slack/node_modules/botkit/lib/CoreBot.js:1090:32
    at Object.bot.findConversation (/home/ethan/node_projects/tripkada-slack/node_modules/botkit/lib/Slackbot_worker.js:751:9)
    at /home/ethan/node_projects/tripkada-slack/node_modules/botkit/lib/CoreBot.js:1086:21
    at next (/home/ethan/node_projects/tripkada-slack/node_modules/ware/lib/index.js:82:27)
    at Ware.run (/home/ethan/node_projects/tripkada-slack/node_modules/ware/lib/index.js:88:3)
    at Object.Botkit.botkit.receiveMessage (/home/ethan/node_projects/tripkada-slack/node_modules/botkit/lib/CoreBot.js:1081:35)
    at handleSlashCommand (/home/ethan/node_projects/tripkada-slack/node_modules/botkit/lib/SlackBot.js:303:22)
    at /home/ethan/node_projects/tripkada-slack/node_modules/botkit/lib/SlackBot.js:226:24

Using botkit 0.4.10. Traced the code: my bot object is undefined.

Should I be spawning a bot? If so, how would I get the bot token if it's an app's bot?

EDIT: Downgraded to 0.4.2, no longer getting the error.

trevor-msgio · 2017-03-08T22:13:35Z

Hey @peterswimm - over here we ran into the same issue. I think this may be due to some of the changes that Slack has made recently.

Since by default, if you enable slash command on your slack app (without a bot user) - you do not ask for the 'bot' permission. And now with the latest Slack change, you cannot add bot permission without a bot user.

It should still be possible to use slash commands without asking for the bot oauth permission (and subsequently adding a bot user) - as slash commands are independent from bot users.

The call to set the user_id of the bot object (which doesn't exist, because we don't have bot oauth permission, see line 5) is here : https://github.com/howdyai/botkit/blob/master/lib/SlackBot.js#L209
I'm also not sure it's really necessary to spawn a bot for a slash command.

Just wanted you to be aware of this. We are looking at the feasibility of submitting a PR for you guys; I think it may be relatively easy to fix.

ritave · 2017-12-13T22:26:11Z

@peterswimm The latest version has moved braces and the functionallity is broken again

In the original PR the if was closed here https://github.com/howdyai/botkit/pull/699/files#diff-ffa8ec227ea6e9babdfc11d5a71ee29dR223

While currently it's closed before getting bot id making the problem reappear: https://github.com/howdyai/botkit/blob/master/lib/SlackBot.js#L217

hbakhtiyor · 2017-12-17T11:32:18Z

i've the same issue with the latest version (0.6.7)

TypeError: Cannot read property 'user_id' of undefined
    at /demo/node_modules/botkit/lib/SlackBot.js:220:34
    at /demo/node_modules/botkit/lib/SlackBot.js:148:17
    at Store.get (/demo/node_modules/botkit/node_modules/jfs/lib/Store.js:203:28)
    at Store.get (/demo/node_modules/botkit/node_modules/jfs/lib/Store.js:345:18)
    at Object.get (/demo/node_modules/botkit/lib/storage/simple_storage.js:54:26)
    at Object.Slackbot.slack_botkit.findTeamById (/demo/node_modules/botkit/lib/SlackBot.js:505:36)
    at Object.Slackbot.slack_botkit.findAppropriateTeam (/demo/node_modules/botkit/lib/SlackBot.js:146:22)
    at Object.Slackbot.slack_botkit.handleWebhookPayload (/demo/node_modules/botkit/lib/SlackBot.js:188:22)
    at /demo/node_modules/botkit/lib/SlackBot.js:134:26
    at Layer.handle [as handle_request] (/demo/node_modules/express/lib/router/layer.js:95:5)
    at next (/demo/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/demo/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/demo/node_modules/express/lib/router/layer.js:95:5)
    at /demo/node_modules/express/lib/router/index.js:281:22
    at Function.process_params (/demo/node_modules/express/lib/router/index.js:335:12)
    at next (/demo/node_modules/express/lib/router/index.js:275:10)

hbakhtiyor · 2018-02-02T16:34:45Z

any updates of the issue? still not resolved in the latest version(0.6.9)

gingeranyhow · 2018-02-27T00:16:37Z

I'm also facing this issue after following the basic slash commands set-up. Any suggested workaround at this time?

izotos · 2018-03-08T10:21:34Z

I've been having the same issue when trying to initiate a dialog, I issued a PR #1281 with changes according to #590 (comment)

This is quite important for us, we could not find a npm version that implements dialogs on Slack that does not have this issue.

erodewald · 2018-04-10T18:20:06Z

This still hasn't been merged? I can't seem to get Slash commands working because of this.

jimmyjames · 2018-04-16T18:16:25Z

Also seeing this issue; verified #1281 is fixing this for me as well. Do we have an ETA on getting that PR reviewed/merged?

Hotfix for issue howdyai#590

mrbar42 · 2018-07-17T08:39:37Z

Work around - We are using another workaround from here #108
which led me to do this (solves both problems):

const controller = Botkit.slackbot({
    disable_startup_messages: true,
    json_file_store: 'tmp/slack.json'
});

// FIX for: https://github.com/howdyai/botkit/issues/108
var bot = controller.spawn({
    token: SLACK_TOKEN
});
bot.api.team.info({}, function(err, response) {
    if (err) throw new Error(err.stack || JSON.stringify(err));
    // FIX2 this is a workaround for https://github.com/howdyai/botkit/issues/590
    response.team.bot = {
        id: 'boti',
        name: 'boti'
    };
    // END FIX2
    controller.saveTeam(response.team, function() {
        // ignore
    })
});
// END FIX

jmeyers91 · 2018-09-24T22:12:58Z

I'm getting this issue and after trying @mrbar42's fix, I'm getting this error:

Error: "missing_scope"
    at bot.api.team.info (/Users/james/projects/emberex-fantasy-football/server/hooks/addSlackBot.hook.js:52:25)
    at Request._callback (/Users/james/projects/emberex-fantasy-football/server/node_modules/botkit/lib/Slack_web_api.js:277:24)
    at Request.self.callback (/Users/james/projects/emberex-fantasy-football/server/node_modules/request/request.js:185:22)
    at Request.emit (events.js:159:13)
    at Request.<anonymous> (/Users/james/projects/emberex-fantasy-football/server/node_modules/request/request.js:1157:10)
    at Request.emit (events.js:159:13)
    at IncomingMessage.<anonymous> (/Users/james/projects/emberex-fantasy-football/server/node_modules/request/request.js:1079:12)
    at Object.onceWrapper (events.js:254:19)
    at IncomingMessage.emit (events.js:164:20)
    at endReadableNT (_stream_readable.js:1054:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

Why is this issue closed? Is that fix supposed to be the right way to get around this user_id issue? It seems #1281 fixes this issue. I'll just fork until it gets merged.

justinemar · 2018-12-11T15:29:26Z

Is there any fixed for this? Currently encountering this on version 0.4.3 currently using @mrbar42 quick fix.

peterswimm · 2018-12-11T18:01:15Z

@justinemar that's a very old botkit, you should upgrade to the latest version and tell us if you are still seeing the trouble

howdyai/botkit#590 https://github.com/1natsu172/Botkit-slack-slash-command-example/blob/master/index.js

joanitad · 2019-03-04T21:17:58Z

I am experiencing the same issue again while creating a custom slash command.
I noticed that the jnv@f35fe53
this fix has been reverted. When I get back this code, it works fine.
I am using the latest version of botkit 0.7.4
How do I work around this?

benbrown · 2019-03-04T22:27:08Z

@joanitad Does your Slack application have a bot associated with it?

Adding one should resolve this.

joanitad · 2019-03-04T22:49:12Z

@benbrown : I have a bot user setup. Is that what you mean? if not, how do I know if the slack application has a bot associated with it?
I am fairly new to create custom slash command.

joanitad · 2019-05-21T17:35:36Z

Hi @benbrown , could you clarify this, I have a bot user associated with the application and the bot is added to #general.I still get this error.

leighman mentioned this issue Jan 10, 2017

Fix slackbutton_slashcommand example #591

Closed

peterswimm added the question label Jan 10, 2017

mbensch mentioned this issue Mar 8, 2017

Fixes slash commands when using internal webserver #699

Merged

peterswimm closed this as completed Jul 5, 2017

peterswimm reopened this Dec 14, 2017

peterswimm assigned benbrown Feb 23, 2018

izotos pushed a commit to izotos/botkit that referenced this issue Mar 8, 2018

Hotfix for issue howdyai#590

e3da1f8

izotos mentioned this issue Mar 8, 2018

Hotfix for issue #590 #1281

Closed

peterswimm closed this as completed May 15, 2018

peterswimm reopened this May 19, 2018

howdyai deleted a comment from hbakhtiyor May 19, 2018

howdyai deleted a comment from izotos May 19, 2018

peterswimm added the bug label May 19, 2018

jnv added a commit to jnv/botkit that referenced this issue May 23, 2018

Merge pull request howdyai#1281 from izotos/issue-590-hotfix

f35fe53

Hotfix for issue howdyai#590

peterswimm closed this as completed Jul 27, 2018

plentybytes mentioned this issue Jul 30, 2018

Cannot display dialog #1333

Closed

jmeyers91 pushed a commit to jmeyers91/botkit that referenced this issue Sep 24, 2018

Fixed howdyai#590

29276e1

interstateone added a commit to interstateone/slash-github-search that referenced this issue Feb 7, 2019

Work around botkit slash command bug

2c7407f

howdyai/botkit#590 https://github.com/1natsu172/Botkit-slack-slash-command-example/blob/master/index.js

CF-Carl added a commit to CF-Carl/botkit that referenced this issue Mar 18, 2019

Hotfix for howdyai#590

21f69c4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot read property 'user_id' when dealing with Slack Apps. #590

Cannot read property 'user_id' when dealing with Slack Apps. #590

kevinwritescode commented Jan 10, 2017

kevinwritescode commented Jan 10, 2017

ethan-sonza commented Feb 9, 2017 •

edited

Loading

trevor-msgio commented Mar 8, 2017

ritave commented Dec 13, 2017

hbakhtiyor commented Dec 17, 2017 •

edited

Loading

hbakhtiyor commented Feb 2, 2018

gingeranyhow commented Feb 27, 2018

izotos commented Mar 8, 2018

erodewald commented Apr 10, 2018

jimmyjames commented Apr 16, 2018

mrbar42 commented Jul 17, 2018

jmeyers91 commented Sep 24, 2018 •

edited

Loading

justinemar commented Dec 11, 2018

peterswimm commented Dec 11, 2018

joanitad commented Mar 4, 2019 •

edited

Loading

benbrown commented Mar 4, 2019

joanitad commented Mar 4, 2019

joanitad commented May 21, 2019

Cannot read property 'user_id' when dealing with Slack Apps. #590

Cannot read property 'user_id' when dealing with Slack Apps. #590

Comments

kevinwritescode commented Jan 10, 2017

kevinwritescode commented Jan 10, 2017

ethan-sonza commented Feb 9, 2017 • edited Loading

trevor-msgio commented Mar 8, 2017

ritave commented Dec 13, 2017

hbakhtiyor commented Dec 17, 2017 • edited Loading

hbakhtiyor commented Feb 2, 2018

gingeranyhow commented Feb 27, 2018

izotos commented Mar 8, 2018

erodewald commented Apr 10, 2018

jimmyjames commented Apr 16, 2018

mrbar42 commented Jul 17, 2018

jmeyers91 commented Sep 24, 2018 • edited Loading

justinemar commented Dec 11, 2018

peterswimm commented Dec 11, 2018

joanitad commented Mar 4, 2019 • edited Loading

benbrown commented Mar 4, 2019

joanitad commented Mar 4, 2019

joanitad commented May 21, 2019

ethan-sonza commented Feb 9, 2017 •

edited

Loading

hbakhtiyor commented Dec 17, 2017 •

edited

Loading

jmeyers91 commented Sep 24, 2018 •

edited

Loading

joanitad commented Mar 4, 2019 •

edited

Loading