No longer working with older Fritz!OS Versions (<7.24) since 0.6.14

[SecretMineDE]

Version 0.6.14 added the wait_device_txbusy-Method with #103. This method uses the api-call getdeviceinfos. This api-call was added with Fritz!OS 7.24 and therefore breaks the option to use this package with older Fritz!OS Versions (I have an older Box with OS 6.88).

As this is the package that HomeAssistant uses for integration Fritz!Home-Devices, this integration is broken for older Fritz!Boxes since HomeAssistant 2025.2.

The error:

Traceback (most recent call last):
  File "/mnt/d/Benutzerdaten/Git/test.py", line 5, in <module>
    data = fritz.set_target_temperature("xx xx", 22)
  File "/home/timon/.local/lib/python3.10/site-packages/pyfritzhome/fritzhome.py", line 301, in set_target_temperature
    wait and self.wait_device_txbusy(ain)
  File "/home/timon/.local/lib/python3.10/site-packages/pyfritzhome/fritzhome.py", line 203, in wait_device_txbusy
    plain = self.get_device_infos(ain)
  File "/home/timon/.local/lib/python3.10/site-packages/pyfritzhome/fritzhome.py", line 239, in get_device_infos
    return self._aha_request("getdeviceinfos", ain=ain)
  File "/home/timon/.local/lib/python3.10/site-packages/pyfritzhome/fritzhome.py", line 117, in _aha_request
    plain = self._request(url, params)
  File "/home/timon/.local/lib/python3.10/site-packages/pyfritzhome/fritzhome.py", line 45, in _request
    rsp.raise_for_status()
  File "/usr/lib/python3/dist-packages/requests/models.py", line 943, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: http://192.168.178.1/webservices/homeautoswitch.lua?switchcmd=getdeviceinfos&sid=xx&ain=xx+xx

(Session-ID and ain removed)

[mib1185]

the wait_device_txbusy should not be called, when wait=False is set on set_target_temperature() 🤔

[SecretMineDE]

Well, HomeAssistant sets that to True: https://github.com/home-assistant/core/blob/master/homeassistant/components/fritzbox/climate.py#L144

With wait=False it works fine, as that is the old behaviour.

[mib1185]

then you should report this issue to homeassistant 😉

[mib1185]

could you please run the following small test script? I want to figure out, how exhausting the api call for getting all device infos is on your box (i assume that it will be more stress for your fritzbox, since based on the FritzOS version you're using, I assume you've a quite old Fritzbox model)

from datetime import datetime
from pyfritzhome import Fritzhome

def _log(line: str):
    print(f"{datetime.now().isoformat()} {line}")

fritz = Fritzhome(host="FRITZ_IP", user="FRITZ_USERNAME", password="FRITZ_PASSWORD")

_log("login")
fritz.login()

for i in range(10):
    _log(f"get_device_elements {i}")
    fritz.get_device_elements()

[SecretMineDE]

There you go:

2025-02-19T06:45:06.632624 login
2025-02-19T06:45:07.000033 get_device_elements 0
2025-02-19T06:45:07.288104 get_device_elements 1
2025-02-19T06:45:07.577859 get_device_elements 2
2025-02-19T06:45:07.870884 get_device_elements 3
2025-02-19T06:45:08.158582 get_device_elements 4
2025-02-19T06:45:08.446324 get_device_elements 5
2025-02-19T06:45:08.735470 get_device_elements 6
2025-02-19T06:45:09.023825 get_device_elements 7
2025-02-19T06:45:09.310180 get_device_elements 8
2025-02-19T06:45:09.597791 get_device_elements 9

My model is a FRITZ!Box Fon WLAN 7360

[mib1185]

thanks for testing ... that's much better than I expected - only ~0.3s per call 👍
How many dect devices (and which types/models) do you have connected to your fritzbox?

Based on this it might be possible to implement a workaround here in the lib, those don't need to add something in HA

[SecretMineDE]

4 thermostates, thats it. Maybe something like 2 more in the future

[mib1185]

ah ok - so no permanently powered/connected devices like a plug or bulb?
I think the wait_device_txbusy needs further improvements - like only process if device is permanently powered/connected and fallback to get_device_elements for FritzOS <7.24.

thanks for all you testing efforts - I'll proceed with these adoptions soon

[SecretMineDE]

Yep, only battery powered devices.

Thank you very much!

[SecretMineDE]

So... the fix is not really working:

 File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 245, in handle_call_service
    response = await hass.services.async_call(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<7 lines>...
    )
    ^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2794, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2837, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 1007, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
        hass, entity, func, data, call.context
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 1079, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/climate/__init__.py", line 955, in async_service_temperature_set
    await entity.async_set_temperature(**kwargs)
  File "/usr/src/homeassistant/homeassistant/components/fritzbox/climate.py", line 147, in async_set_temperature
    await self.hass.async_add_executor_job(
        self.data.set_target_temperature, target_temp, True
    )
  File "/usr/local/lib/python3.13/concurrent/futures/thread.py", line 59, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.13/site-packages/pyfritzhome/devicetypes/fritzhomedevicethermostat.py", line 137, in set_target_temperature
    return self._fritz.set_target_temperature(self.ain, temperature, wait)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/pyfritzhome/fritzhome.py", line 311, in set_target_temperature
    wait and self.wait_device_txbusy(ain)
             ~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/usr/local/lib/python3.13/site-packages/pyfritzhome/fritzhome.py", line 216, in wait_device_txbusy
    if txbusy[0].text == "0":
       ~~~~~~^^^
IndexError: list index out of range

I've looked at the response from get_device_element, and the xml looks like this:

<?xml version="1.0"?>
<device identifier="xx xx" id="18" functionbitmask="320" fwversion="05.21" manufacturer="AVM" productname="Comet DECT">
  <present>1</present>
  <name>NAME</name>
  <temperature>
    <celsius>195</celsius>
    <offset>-5</offset>
  </temperature>
  <hkr>
    <tist>39</tist>
    <tsoll>45</tsoll>
    <absenk>37</absenk>
    <komfort>42</komfort>
    <lock>0</lock>
    <devicelock>0</devicelock>
    <errorcode>0</errorcode>
    <batterylow>0</batterylow>
    <nextchange>
      <endperiod>0</endperiod>
      <tchange>42</tchange>
    </nextchange>
  </hkr>
</device>

So, the older models don't even have the txbusy-attribute, the api documentation also confirms this.

imo the "best" solution would to just return True here, which should just work like the old implementation: https://github.com/hthiery/python-fritzhome/blob/0.6.16/pyfritzhome/fritzhome.py#L213

I`ve tested exactly that change and it seems to work fine.

[mib1185]

mehhh ... didn't expect, that txbusy is something which had been added later 🙈 it has been added in 7.20, so we've to check if txbusy is available and if not, just return True