Fallback to getdevicelistinfos in wait for txbusy #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mib1185
commented
Feb 19, 2025
mib1185
commented
- fixes No longer working with older Fritz!OS Versions (<7.24) since 0.6.14 #115
flabbamann
reviewed
Feb 19, 2025
| try: | ||
| plain = self.get_device_infos(ain) | ||
| dom = ElementTree.fromstring(plain) | ||
| except exceptions.HTTPError: |
There was a problem hiding this comment.
Hi @mib1185,
I think we should check for the status code here, to avoid sending more requests to the box in case of other errors 🙂.
There was a problem hiding this comment.
tbh. I can not predict if there are other codes besides 400 returned on even older FritzOS - because of this and that it would only be one additional request for the whole login session, i've not add a check for the response code, but just for httperrors - if there will be an connection error, then it will raise as already done before
There was a problem hiding this comment.
I remember getting 503 from a Fritzbox while testing something, but I don't remember how that happened 😉.
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.