-
Notifications
You must be signed in to change notification settings - Fork 33
Add RTS interfaces #36
Conversation
Pull Request Test Coverage Report for Build 140
💛 - Coveralls |
@niuzhenguo Can you please help update if the coverall result would be blocker for merge. Also suggest what steps could possibly help resolve it. |
@Savasw That's because tests coverage decreased with the change, you can check the file list above to find which parts missing coverage. I'm not sure if it's a blocker for merge now but we do not care much about that before :P. @freesky-edward can you please help to confirm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contributing, regarding to the coverage rate, it should pass before merging it, but I am not concerned this much. It can go if all is good enough.
I have some confusion about the relationship of TE, template, environment. it looks TE is an abstract struct of other two. if so, I would suggest to separate it from utility file(util.go).
|
||
// Fetch fetches the contents of a TE from its URL. Once a TE structure has a | ||
// URL, call the fetch method to fetch the contents. | ||
func (t *TE) Fetch() error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is an internal method, I would prefer to name it starting with lowercase letter.
@freesky-edward As discussed, for RTS Stack, we have followed code architecture from openstack gophercloud where TE is abstract for both environment and template as there are lot of common features that work for both. Also Fetch function is not used externally at the moment but could be useful for end users separately to fetch content from URL. |
@Savasw thanks for your response, LGTM |
What this PR does / why we need it: This PR adds RTS interfaces.
Special notes for your reviewer: NONE
Release noteNONE