Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Conversation

frisky-dis
Copy link
Contributor

What this PR does / why we need it: This PR adds RTS software config and deployment services interfaces

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer: None

Release note: None

@frisky-dis frisky-dis changed the title Rts dev phase2 add RTS software config and deployment services interface support Jul 12, 2018
@coveralls
Copy link

coveralls commented Jul 12, 2018

Pull Request Test Coverage Report for Build 163

  • 155 of 220 (70.45%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 66.297%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openstack/rts/v1/softwaredeployment/results.go 25 27 92.59%
openstack/rts/v1/softwareconfig/results.go 25 27 92.59%
openstack/rts/v1/softwareconfig/requests.go 40 66 60.61%
openstack/rts/v1/softwaredeployment/requests.go 53 88 60.23%
Totals Coverage Status
Change from base Build 156: 0.7%
Covered Lines: 2992
Relevant Lines: 4513

💛 - Coveralls

@freesky-edward
Copy link
Contributor

LGTM, should #36 be closed?

@Savasw
Copy link
Contributor

Savasw commented Jul 13, 2018

There is no dependency as such but it would be good to merge #36 first if possible

@freesky-edward freesky-edward merged commit 1aef9d9 into huaweicloud:master Jul 13, 2018
@simrannagra simrannagra deleted the rts_dev_phase2 branch August 6, 2018 06:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants