🐛 Fix settings modal not resetting its state #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should not mutate passed prop
coyotte508
reviewed
May 17, 2023
coyotte508
approved these changes
May 17, 2023
Co-authored-by: Eliott C. <coyotte508@gmail.com>
This reverts commit ba1938e.
ice91
pushed a commit
to ice91/chat-ui
that referenced
this pull request
Oct 30, 2024
* 🐛 Fix settings modal not resetting its state should not mutate passed prop * make variable dynamic in case it's updated from outside Co-authored-by: Eliott C. <coyotte508@gmail.com> * Revert "make variable dynamic in case it's updated from outside" This reverts commit ba1938e. --------- Co-authored-by: Eliott C. <coyotte508@gmail.com>
maksym-work
pushed a commit
to siilats/chat-ui
that referenced
this pull request
Jul 2, 2025
* 🐛 Fix settings modal not resetting its state should not mutate passed prop * make variable dynamic in case it's updated from outside Co-authored-by: Eliott C. <coyotte508@gmail.com> * Revert "make variable dynamic in case it's updated from outside" This reverts commit ba1938e. --------- Co-authored-by: Eliott C. <coyotte508@gmail.com>
Matsenas
pushed a commit
to Matsenas/chat-ui
that referenced
this pull request
Jul 4, 2025
* 🐛 Fix settings modal not resetting its state should not mutate passed prop * make variable dynamic in case it's updated from outside Co-authored-by: Eliott C. <coyotte508@gmail.com> * Revert "make variable dynamic in case it's updated from outside" This reverts commit ba1938e. --------- Co-authored-by: Eliott C. <coyotte508@gmail.com>
gary149
pushed a commit
to gary149/chat-ui
that referenced
this pull request
Aug 29, 2025
* 🐛 Fix settings modal not resetting its state should not mutate passed prop * make variable dynamic in case it's updated from outside Co-authored-by: Eliott C. <coyotte508@gmail.com> * Revert "make variable dynamic in case it's updated from outside" This reverts commit ba1938e. --------- Co-authored-by: Eliott C. <coyotte508@gmail.com>
gary149
pushed a commit
to gary149/chat-ui
that referenced
this pull request
Aug 29, 2025
* 🐛 Fix settings modal not resetting its state should not mutate passed prop * make variable dynamic in case it's updated from outside Co-authored-by: Eliott C. <coyotte508@gmail.com> * Revert "make variable dynamic in case it's updated from outside" This reverts commit ba1938e. --------- Co-authored-by: Eliott C. <coyotte508@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following bug:
This is because the input is mutating the
settingsprop.