Skip to content

Fix stop generating button #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2023
Merged

Fix stop generating button #244

merged 2 commits into from
May 23, 2023

Conversation

TP-O
Copy link
Contributor

@TP-O TP-O commented May 19, 2023

The current behavior overlays user input, so I think making it similar to chatGPT would be better.
image

New in desktop
image

New in mobile
image

@Grsmto Grsmto requested a review from gary149 May 19, 2023 09:10
@Grsmto
Copy link
Contributor

Grsmto commented May 19, 2023 •
edited
Loading

Hey @TP-O thanks for your contrib again!
There is no way you could do this without relying on JS to display the desktop or mobile version? (and instead do with CSS Media Queries). The difference between the two versions doesn't seem to huge to need some JS (unless the positioning is a deal breaker).

@TP-O
Copy link
Contributor Author

TP-O commented May 19, 2023

Hey @TP-O thanks for your contrib again! There is no way you could do this without relying on JS to display the desktop or mobile version? (and instead do with CSS Media Queries). The difference between the two versions doesn't seem to huge to need some JS (unless the positioning is a deal breaker).

I will fix it 🤣

@nsarrazin nsarrazin self-requested a review May 23, 2023 08:39
nsarrazin
nsarrazin approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me at least this is working great! I tested both breakpoints and they both well.

@gary149 let me know if you want to have a look yourself

@gary149
Copy link
Collaborator

gary149 commented May 23, 2023

LGTM, nice one.

@gary149 gary149 merged commit 293ff91 into huggingface:main May 23, 2023
@TP-O TP-O deleted the fix-stop-btn branch May 23, 2023 12:14
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
@TP-O
Fix stop generating button (huggingface#244)
a7a0fd8 
* fix stop btn

* use media query
maksym-work pushed a commit to siilats/chat-ui that referenced this pull request Jul 2, 2025
@TP-O
Fix stop generating button (huggingface#244)
d492075 
* fix stop btn

* use media query
Matsenas pushed a commit to Matsenas/chat-ui that referenced this pull request Jul 4, 2025
@TP-O
Fix stop generating button (huggingface#244)
12fd68c 
* fix stop btn

* use media query
gary149 pushed a commit to gary149/chat-ui that referenced this pull request Aug 29, 2025
@TP-O
Fix stop generating button (huggingface#244)
18b84f8 
* fix stop btn

* use media query
gary149 pushed a commit to gary149/chat-ui that referenced this pull request Aug 29, 2025
@TP-O
Fix stop generating button (huggingface#244)
22824fd 
* fix stop btn

* use media query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gary149 gary149 Awaiting requested review from gary149

1 more reviewer

@nsarrazin nsarrazin nsarrazin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TP-O @Grsmto @gary149 @nsarrazin