Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images Interpolation with Stable Diffusion #42

Merged
merged 11 commits into from
Feb 27, 2024

Conversation

AkiRusProd
Copy link
Contributor

What does this PR do?

This notebook shows several ways to interpolate images using Stable Diffusion. Image interpolation using Stable Diffusion is the process of creating intermediate images that smoothly transition from one given image to another, using a generative model based on diffusion.

@MKhalusova

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@AkiRusProd AkiRusProd marked this pull request as draft February 21, 2024 19:47
@AkiRusProd AkiRusProd marked this pull request as ready for review February 21, 2024 19:50
@MKhalusova
Copy link
Contributor

Thank you for the contribution! Diffusion models are not my strong suit, so I'd like to ask @sayakpaul for a review.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

notebooks/en/stable_diffusion_interpolation.ipynb Outdated Show resolved Hide resolved
notebooks/en/stable_diffusion_interpolation.ipynb Outdated Show resolved Hide resolved
notebooks/en/stable_diffusion_interpolation.ipynb Outdated Show resolved Hide resolved
notebooks/en/stable_diffusion_interpolation.ipynb Outdated Show resolved Hide resolved
notebooks/en/stable_diffusion_interpolation.ipynb Outdated Show resolved Hide resolved
@sayakpaul
Copy link
Member

Code wise, this look very nice to me ❤️ Thanks a lot for working on this. You could also consider discussing one/two use cases of image interpolation.

I'd ask @MKhalusova to check the wording, phrases, etc.

@AkiRusProd
Copy link
Contributor Author

AkiRusProd commented Feb 25, 2024

Hello. I have made changes to the code as per @sayakpau's suggestions. (Also I opened a pull request to upload the files: https://huggingface.co/datasets/huggingface/cookbook-images/discussions/7)
@MKhalusova

@AkiRusProd
Copy link
Contributor Author

As for more use cases of image interpolation. I'll think about it.

@sayakpaul
Copy link
Member

As for more use cases of image interpolation. I'll think about it.

Just to be clear, I am not asking for including more examples. You have already shown four -- which is more than enough. I am asking you to think of some use cases that we could include at the beginning of the notebook that could further motivate the readers.

@AkiRusProd
Copy link
Contributor Author

AkiRusProd commented Feb 26, 2024

Hi, thanks for taking a look at this notebook. I have made changes to the code based on @sayakpau's suggestions (fixed links to gifs and added some different use cases in the introduction).
@MKhalusova

notebooks/en/stable_diffusion_interpolation.ipynb Outdated Show resolved Hide resolved
notebooks/en/stable_diffusion_interpolation.ipynb Outdated Show resolved Hide resolved
notebooks/en/stable_diffusion_interpolation.ipynb Outdated Show resolved Hide resolved
notebooks/en/stable_diffusion_interpolation.ipynb Outdated Show resolved Hide resolved
notebooks/en/stable_diffusion_interpolation.ipynb Outdated Show resolved Hide resolved
notebooks/en/stable_diffusion_interpolation.ipynb Outdated Show resolved Hide resolved
notebooks/en/stable_diffusion_interpolation.ipynb Outdated Show resolved Hide resolved
@MKhalusova
Copy link
Contributor

Thanks @sayakpaul for a review!
I looked over the notebook - there are a few finishing touches to address, and then we should be good to merge. The PR with images is merged now too.

@AkiRusProd
Copy link
Contributor Author

AkiRusProd commented Feb 26, 2024

Hello, thanks for the review! But I have a question. In the introduction, I already covered three use cases for image interpolation using Stable Diffusion. I don't quite understand what exactly should I do? And I made the rest of the changes in accordance with your advice. Maybe you mean applications that already use this feature in the real world?
@MKhalusova

@AkiRusProd
Copy link
Contributor Author

Hello, what are our next steps?
@MKhalusova

@MKhalusova
Copy link
Contributor

Looks good to merge! But I will do social communications about this notebook tomorrow.

@MKhalusova MKhalusova merged commit d51b523 into huggingface:main Feb 27, 2024
1 check passed
@AkiRusProd
Copy link
Contributor Author

@MKhalusova , Thank You so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants