Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and update several links in notebook «Advanced RAG on Hugging Face» #69

Merged
merged 3 commits into from
May 7, 2024

Conversation

rnckp
Copy link
Contributor

@rnckp rnckp commented Apr 1, 2024

  • Fix some typos
  • Add some missing words
  • Update several links

Btw: Very helpful notebooks - thanks for making this available. Very much appreciated. 👍

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rnckp rnckp changed the title Fix typos and update several links Fix typos and update several links in notebook «Advanced RAG on Hugging Face» Apr 1, 2024
@aymeric-roucher
Copy link
Collaborator

After undoing the change that I mentioned, all will be perfect! Thank you for adding these changes @rnckp 🤗

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@merveenoyan
Copy link
Collaborator

@rnckp thanks for the nits, I left two comments

- Fix typo in comment in code cell of first distribution plot
@rnckp
Copy link
Contributor Author

rnckp commented Apr 21, 2024

@merveenoyan @aymeric-roucher I have changed the code according to your comments. 👍

Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for working on this!

@merveenoyan merveenoyan merged commit a2d4bcc into huggingface:main May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants