Refactor instructpix2pix lora to support peft #10205
Merged
+263
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
reviewed
Dec 13, 2024
examples/research_projects/instructpix2pix_lora/train_instruct_pix2pix_lora.py
Outdated
Show resolved
Hide resolved
sayakpaul
reviewed
Dec 13, 2024
examples/research_projects/instructpix2pix_lora/train_instruct_pix2pix_lora.py
Outdated
Show resolved
Hide resolved
sayakpaul
reviewed
Dec 13, 2024
|
Thanks for looking into the PR. Sorry for the delay. I have made the changes you have suggested and trained the model for only 3 epochs (1500 steps). I have attached a screenshot of cartoonizing one of the images. |
sayakpaul
reviewed
Dec 22, 2024
sayakpaul
reviewed
Dec 22, 2024
examples/research_projects/instructpix2pix_lora/train_instruct_pix2pix_lora.py
Show resolved
Hide resolved
sayakpaul
approved these changes
Dec 22, 2024
…_pix2pix_lora.py Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
|
can you run |
|
Thanks for your awesome contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructpix2pix_lora to use PEFT
Fixes
As discussed in issues: #10062
Tested on Google Colab by running the sample train command provided in README.
Who can review?
@sayakpaul @duduke121