Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reference to the name 'Sampler' #1172

Merged
merged 2 commits into from Nov 10, 2022
Merged

Conversation

apolinario
Copy link
Contributor

  • Facilitate people that are familiar with the name samplers to understand that we call that schedulers
  • Better SEO if people are googling for samplers to find our library as well

- Facilitate people that are familiar with the name samplers to understand that we call that schedulers
- Better SEO if people are googling for samplers to find our library as well
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@patrickvonplaten
Copy link
Contributor

Feel free to merge whenever you want @apolinario :-)

@apolinario apolinario marked this pull request as ready for review November 9, 2022 19:06
@patrickvonplaten
Copy link
Contributor

@apolinario would you like me to merge? Feel free to go ahead since you have one ✔️

@apolinario apolinario merged commit a09d475 into main Nov 10, 2022
@kashif kashif deleted the scheduler-sampler-seo branch March 19, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants