Flax tests: don't hardcode number of devices #1175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to test on CPU/GPU. However, expected slices are only checked when there are 8 devices.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
Slightly dangerous as we're now allowing the tests to pass when we're running on a single GPU or TPU core, but ok for me! |
|
@patrickvonplaten The reason is that tests failed when running slow tests in my computer (with Flax installed). I thought it would be ok to avoid hardcoding the number of devices, but as an alternative we could write a decorator that requires an actual TPU node. Should I do that instead? |
|
Ok for me think I think we always test on v3-8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to test on CPU/GPU. However, expected slices are only checked when there are 8 devices.