Skip to content

Support one-string prompts and custom image size in LDM #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2022
Merged

Support one-string prompts and custom image size in LDM #212

merged 2 commits into from
Aug 18, 2022

Conversation

anton-l
Copy link
Member

@anton-l anton-l commented Aug 18, 2022

Fixes #211

Makes sure that LDMTextToImagePipeline can be called with pipe("some prompt"), similar to StableDiffusionPipeline

@anton-l anton-l requested review from pcuenca and patil-suraj August 18, 2022 14:27
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 18, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@anton-l
Copy link
Member Author

anton-l commented Aug 18, 2022

note to self: add type hints and custom image sizes to LDM as well

patil-suraj
patil-suraj reviewed Aug 18, 2022
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's also add custom height, width support for this. Think this should pretty much look like stable-dffusion pipeline.

@anton-l anton-l changed the title Support one-string prompts in LDM Support one-string prompts and custom image size in LDM Aug 18, 2022
@anton-l
Copy link
Member Author

anton-l commented Aug 18, 2022

@patil-suraj yep, decided to bundle them here too

pcuenca
pcuenca approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and it works fine too!

@anton-l anton-l merged commit e30e1b8 into main Aug 18, 2022
@anton-l anton-l deleted the ldm-str-prompts branch August 18, 2022 15:55
PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
@AmosLewis
Remove tf package dep for SharkDownloader tflite tests (huggingface#212)
dc1a283
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@anton-l
Support one-string prompts and custom image size in LDM (huggingface#212
b1e3aef 
)

* Support one-string prompts in LDM

* Add other features from SD too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcuenca pcuenca pcuenca approved these changes

+1 more reviewer

@patil-suraj patil-suraj patil-suraj left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception raised in LDMTextToImagePipeline
4 participants
@anton-l @HuggingFaceDocBuilderDev @pcuenca @patil-suraj