Skip to content

Update xFormers docs #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2023
Merged

Update xFormers docs #2208

merged 1 commit into from
Feb 1, 2023

Conversation

pcuenca
Copy link
Member

@pcuenca pcuenca commented Feb 1, 2023

Fixes #1731

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 1, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

kashif
kashif approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@kashif kashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! Do we want to add it to the setup.py?

@pcuenca
Copy link
Member Author

pcuenca commented Feb 1, 2023

LGTM! Thanks! Do we want to add it to the setup.py?

As an extra? I'm not sure we should, it's more of an user preference for me. Happy to submit a commit if you think it's important/useful.

@kashif
Copy link
Contributor

kashif commented Feb 1, 2023

no its ok! It might cause more issues (especially since it is so tied in with the pytorch version...)

patrickvonplaten
patrickvonplaten approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pcuenca pcuenca merged commit 3816c9a into main Feb 1, 2023
@pcuenca pcuenca deleted the doc-xformers-update branch February 1, 2023 18:56
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@pcuenca
Update xFormers docs (huggingface#2208)
6ab1958 
Update xFormers docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashif kashif kashif approved these changes

@patil-suraj patil-suraj Awaiting requested review from patil-suraj

+1 more reviewer

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update xformers installation docs when xformers 0.0.16 is released
4 participants
@pcuenca @HuggingFaceDocBuilderDev @kashif @patrickvonplaten