Skip to content

img2img.multiple.controlnets.pipeline #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2023
Merged

img2img.multiple.controlnets.pipeline #2833

merged 2 commits into from
Mar 30, 2023

Conversation

mikegarts
Copy link
Contributor

No description provided.

@mikegarts mikegarts mentioned this pull request Mar 26, 2023
Closed
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 26, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@mikegarts
Copy link
Contributor Author

mikegarts commented Mar 26, 2023 •
edited
Loading

Regression for single controlnet use case:
https://colab.research.google.com/drive/1CfJO2rNKDPMJeLrTXVi7e03-QE0VruwE?usp=sharing

Multiple controlnets use case:
https://colab.research.google.com/drive/1e-yLAoLFUlGBSQqcGGHaMjiaOOdTlw3L?usp=sharing

image

:)

@mikegarts
Copy link
Contributor Author

This is not the ideal way to handle the controlnet_guidance_{start,stop} (addition by @hyowon-ha).
Right now they control the start/stop cond globally and one can't pass a list to control each controlnet separately.

Ideally, imho, - it would be cool to be able to pass them (as lists) to MultiControlNetModel imho (the same way controlnet_conditioning_scale is handled) - but this requires a modification of the MultiControlNetModel.

@mikegarts
Copy link
Contributor Author

@williamberman since you reviewed a similar pr of mine, tagging you (sorry in advance if you are not the person)

patrickvonplaten
patrickvonplaten approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@patrickvonplaten
Copy link
Contributor

@mikegarts could you take a quick look as well? :-)

@mikegarts
Copy link
Contributor Author

@mikegarts could you take a quick look as well? :-)

Sure, but since I proposed the pr in the first place I might be a little biased here :-)

@patrickvonplaten
Copy link
Contributor

@mikegarts could you take a quick look as well? :-)

Sure, but since I proposed the pr in the first place I might be a little biased here :-)

Haha, upps sorry 200 GitHub notifications per day make me say weird things sometimes. Sorry about this & thanks for reviewing yourself ❤️

@patrickvonplaten patrickvonplaten merged commit 1d033a9 into huggingface:main Mar 30, 2023
This was referenced Apr 14, 2023
Closed
Closed
w4ffl35 pushed a commit to w4ffl35/diffusers that referenced this pull request Apr 14, 2023
@mikegarts @w4ffl35
img2img.multiple.controlnets.pipeline (huggingface#2833)
a3917ab 
* img2img.multiple.controlnets.pipeline

* remove comments

---------

Co-authored-by: mishka <gartsocial@gmail.com>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@mikegarts
img2img.multiple.controlnets.pipeline (huggingface#2833)
250ec8f 
* img2img.multiple.controlnets.pipeline

* remove comments

---------

Co-authored-by: mishka <gartsocial@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikegarts @HuggingFaceDocBuilderDev @patrickvonplaten