[MPS] Make sure it doesn't break torch < 1.12 #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
commented
Sep 8, 2022
| torch_device = "mps" if torch.backends.mps.is_available() else torch_device | ||
| is_torch_higher_equal_than_1_12 = version.parse(version.parse(torch.__version__).base_version) >= version.parse("1.12") | ||
|
|
||
| if is_torch_higher_equal_than_1_12: |
There was a problem hiding this comment.
cc @pcuenca
We need to be careful when using features that are quite new in PyTorch. This would have broken PyTorch 1.11 here.
In the future we should run backwards compatible version tests starting from our oldest supported version. For now we need to be a bit careful when adding very new features to not break PyTorch 1.11
There was a problem hiding this comment.
Sorry, I thought about asking when I first added the line but then forgot. Thanks for fixing it.
|
The documentation is not available anymore as the PR was closed or merged. |
PhaneeshB
pushed a commit
to nod-ai/diffusers
that referenced
this pull request
Mar 1, 2023
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* [MPS] Make sure it doesn't break torch < 1.12 * up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.