Fix Disentangle ONNX and non-ONNX pipeline #4656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Is this ready for a review? :-) |
|
@patrickvonplaten Ready to review |
|
@patrickvonplaten Following up on this |
patrickvonplaten
approved these changes
Aug 25, 2023
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* initial commit to fix inheritance issue * clean up sd onnx upscale * clean up
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* initial commit to fix inheritance issue * clean up sd onnx upscale * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the
OnnxStableDiffusionUpscalePipelinein the following wayStableDiffusionUpscalePipelineand replaces it with inheritance fromDiffusionPipelineso that it aligns with the Diffusers design philosophytorchtensors and torch based operations (generator, concatentation etc) in favour ofnumpyarrays and operations so that this pipeline is more in line with the design of theOnnxStableDiffusionImg2ImgPipelineand OnnxStableDiffusionPipeline`Fixes # (issue)
#4440
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.