-
Notifications
You must be signed in to change notification settings - Fork 6.3k
fix auto_pipeline: pass kwargs to load_config #4793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job - that looks correct to me!
Can we apply this change also to all other autopipelines to make sure they are also fixed?
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Super! Sorry, one last thing: Let's maybe add a small test to check that everything works as expected would be nice - e.g. maybe just passing the |
I think it will be pretty tricky to test, first time to find out the original class name for the pipeline, and then it will be called again once we dispatch to the |
Hmm yeah sorry this:
wasn't very clear / didn't make too much sense 😅 Then let's maybe more or less use the reproducible code snippet here: #4727 (comment) as a way of testing no? Using Maybe you can write a test similar to this one: diffusers/tests/pipelines/test_pipelines.py Line 441 in c4d2823
|
So the code snippet here #4727 (comment) isn't reproducible as it is: I think they happened to have an outdated copy of the cached model. I made a test to try to recreate this edge case by modifying the commit ID. Let me know if this is ok, or if there is an easier/better way to test. |
Looks great - thanks! |
* fix --------- Co-authored-by: yiyixuxu <yixu310@gmail,com> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
* fix --------- Co-authored-by: yiyixuxu <yixu310@gmail,com> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
This PR fix #4727
We now pass relevant kwargs to
load_config()
when we retrieve the config fileI only updated for Text2Image here, will update other auto pipelines too if it's ok