-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Fix get_dummy_inputs for Stable Diffusion Inpaint Tests #4845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get_dummy_inputs for Stable Diffusion Inpaint Tests #4845
Conversation
…oduce a random image and a white mask_image.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Hey @dg845, thanks a lot for the PR - the change makes a lot of sense! Could you maybe try to update the failing tests? Think then we can merge |
The tests which are currently failing are:
which makes sense, given that the input image and mask have changed. @patrickvonplaten, do you know what reference implementation(s) were used to get the expected slices for (Looking through the code, the only fast tests that use an |
Hey @dg845, Could you maybe just update the |
I have updated the |
Test failure is unrelated - merging! |
…4845) * Change StableDiffusionInpaintPipelineFastTests.get_dummy_inputs to produce a random image and a white mask_image. * Add dummy expected slices for the test_stable_diffusion_inpaint tests. * Remove print statement --------- Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
What does this PR do?
This PR fixes the
get_dummy_inputs
method forStableDiffusionInpaintPipelineFastTests
. Currently,get_dummy_inputs
creates a blackimage
and blackmask_image
, which means that we are technically not repainting the image at all, which doesn't seem like the right behavior.This PR is a spin-off of #4536, where the above issue was noticed (see #4536 (comment)).
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@patrickvonplaten
@yiyixuxu