Skip to content

Conversation

bghira
Copy link
Contributor

@bghira bghira commented Sep 19, 2023

What does this PR do?

Adds x-prediction / prediction_type=sample support.

I sort of worked it out how to do this on my own, would love feedback.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me - @sayakpaul wdyt?

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

Any exciting results you wanted also to share benefitting from this objective?

@bghira
Copy link
Contributor Author

bghira commented Sep 19, 2023

i havent gotten the chance to train an x-pred model ... yet =) maybe someone will beat me to it now

@bghira
Copy link
Contributor Author

bghira commented Sep 19, 2023

The reason I added sample prediction training support is due to the results in the Bytedance paper, "Common Diffusion Noise Schedules and Sample Steps are Flawed" that demonstrated similar visual acuity to velocity objective. The paper noted that x-prediction results tend to be blurrier than v-prediction, but that both are of higher quality than noise (epsilon) prediction.

@sayakpaul sayakpaul merged commit 81331f3 into huggingface:main Sep 19, 2023
@bghira bghira deleted the feature/train-sample-prediction-type branch September 19, 2023 16:04
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
huggingface#5095)

Co-authored-by: bghira <bghira@users.github.com>
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants