changed channel parameters for UNET and VAE. Changed configs parameters of CLIPText #5370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…size with increased attention heads and intermediate size
|
@DN6 Kindly review and awaiting your feedback. Thank you! |
|
I thought assertion errors were inevitable since the parametric change will influence those values.....do i need to consider changing the assertion checks such as ''np.abs(image_slice.flatten() - expected_slice).max() < 1e-2'' into the range that is acceptable? |
| image_slice = image[0, -3:, -3:, -1] | ||
|
|
||
| assert image.shape == (1, 64, 64, 3) | ||
| expected_slice = np.array([0.4873, 0.5443, 0.4845, 0.5004, 0.5549, 0.4850, 0.5191, 0.4941, 0.5065]) |
There was a problem hiding this comment.
We will have to update the expected values here cc @DN6 can you help?
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
Thank you all! |
4 tasks
mhetrerajat
pushed a commit
to mhetrerajat/diffusers
that referenced
this pull request
Oct 23, 2023
…rs of CLIPText (huggingface#5370) * changed channel parameters for UNET and VAE. Decreased hidden layers size with increased attention heads and intermediate size * changed the assertion check range * clean up --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…rs of CLIPText (huggingface#5370) * changed channel parameters for UNET and VAE. Decreased hidden layers size with increased attention heads and intermediate size * changed the assertion check range * clean up --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally (skipping slow runs), faced some assertion errors due to model changes.
What does this PR do?
Fixes #5262
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.