-
Notifications
You must be signed in to change notification settings - Fork 6.4k
[PixArt-Alpha] Introduce resolution binning #5739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: lawrence-cj <jschen@mail.dlut.edu.cn>
@DN6 |
No problem on my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice addition! Let's add a test as well and please no torchvision
dependency 🙏
The documentation is not available anymore as the PR was closed or merged. |
@patrickvonplaten I have added a pure PyTorch implementation. The reason why we cannot do a fast test for resolution binning is that even for very resolutions, This is why I choose to add a slow test for it and include that in #5752 (as it requires changing the assertion values anyway). Is that okay? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean!
* feat: add resolution binning Co-authored-by: lawrence-cj <jschen@mail.dlut.edu.cn> * rename * debug * add :test * remove unused variable * set resolution_binning to False. --------- Co-authored-by: lawrence-cj <jschen@mail.dlut.edu.cn>
* feat: add resolution binning Co-authored-by: lawrence-cj <jschen@mail.dlut.edu.cn> * rename * debug * add :test * remove unused variable * set resolution_binning to False. --------- Co-authored-by: lawrence-cj <jschen@mail.dlut.edu.cn>
What does this PR do?
Introduces resolution binning as originally done by @lawrence-cj in #5716.
This is particularly useful for generating non-square images.
Quality comparison
1024x2048
1536x720
Code