[Benchmarks] fix: lcm benchmarking reporting #6198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
commented
Dec 17, 2023
| @@ -162,6 +162,25 @@ def run_inference(self, pipe, args): | |||
| guidance_scale=1.0, | |||
| ) | |||
|
|
|||
| def benchmark(self, args): | |||
There was a problem hiding this comment.
This ensures that the overridden get_result_filepath() in the LCMLoRATextToImageBenchmark class gets called properly.
donhardman
pushed a commit
to donhardman/diffusers
that referenced
this pull request
Dec 18, 2023
* fix: lcm benchmarking reporting * fix generate_csv_dict call.
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* fix: lcm benchmarking reporting * fix generate_csv_dict call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes how the LCM benchmark numbers are reported.