Skip to content

TST Fix LoRA test that fails with PEFT >= 0.7.0 #6216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 21, 2023
Merged

TST Fix LoRA test that fails with PEFT >= 0.7.0 #6216

merged 3 commits into from
Dec 21, 2023

Conversation

BenjaminBossan
Copy link
Member

What does this PR do?

Resolves #6185 (LoRA test failing with PEFT >= 0.7.0).

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

younesbelkada
younesbelkada approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@patrickvonplaten patrickvonplaten mentioned this pull request Dec 18, 2023
Closed
sayakpaul
sayakpaul approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much! Works for me in light of #6185 (comment).

@BenjaminBossan
Copy link
Member Author

@sayakpaul Not sure what the norms for for diffusers. Shall I (squash and) merge this PR or do I wait for a diffusers core maintainer to do that?

@sayakpaul
Copy link
Member

@patrickvonplaten's #6185 (comment)

@sayakpaul
Copy link
Member

@patrickvonplaten a gentle ping here.

patrickvonplaten
patrickvonplaten approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patrickvonplaten patrickvonplaten merged commit 43979c2 into huggingface:main Dec 21, 2023
@BenjaminBossan BenjaminBossan deleted the tst-fix-failing-lora-test-peft-0.7 branch December 21, 2023 11:05
donhardman pushed a commit to donhardman/diffusers that referenced this pull request Dec 29, 2023
@BenjaminBossan @sayakpaul @donhardman
TST Fix LoRA test that fails with PEFT >= 0.7.0 (huggingface#6216)
b7ea281 
See huggingface#6185 for context.

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@BenjaminBossan @sayakpaul
TST Fix LoRA test that fails with PEFT >= 0.7.0 (huggingface#6216)
124d390 
See huggingface#6185 for context.

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayakpaul sayakpaul sayakpaul approved these changes

+2 more reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@younesbelkada younesbelkada younesbelkada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LoRA fusion tests] SDXL LoRA tests with fusion when using peft
5 participants
@BenjaminBossan @HuggingFaceDocBuilderDev @sayakpaul @patrickvonplaten @younesbelkada