Fix Compatibility Issues in stable_diffusion_xl_reference.py #6251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two primary issues in the stable_diffusion_xl_reference.py script which rendered it incompatible with the current version. Firstly, the addition of time ids did not incorporate the projection dimension from text_encode_2. This omission has been corrected to ensure proper integration. Secondly, errors were encountered due to the absence of the 'scale' keyword argument in the hacked_DownBlock2D_forward() and hacked_UpBlock2D_forward() functions. The signatures of these functions have been updated to include this argument, resolving the errors and enhancing overall functionality.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This commit addresses two primary issues in the stable_diffusion_xl_reference.py script which rendered it incompatible with the current version. Firstly, the addition of time ids did not incorporate the projection dimension from text_encode_2. This omission has been corrected to ensure proper integration. Secondly, errors were encountered due to the absence of the 'scale' keyword argument in the hacked_DownBlock2D_forward() and hacked_UpBlock2D_forward() functions. The signatures of these functions have been updated to include this argument, resolving the errors and enhancing overall functionality.
|
Cc: @zideliu who contributed this pipeline for a review. |
|
@zideliu Do you have any advice? |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Great work! |
yiyixuxu
approved these changes
Feb 8, 2024
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…gface#6251) * Fix Compatibility Issues in stable_diffusion_xl_reference.py --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com> Co-authored-by: YiYi Xu <yixu310@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses two primary issues in the stable_diffusion_xl_reference.py script which rendered it incompatible with the current version. Firstly, the addition of time ids did not incorporate the projection dimension from text_encode_2. This omission has been corrected to ensure proper integration. Secondly, errors were encountered due to the absence of the 'scale' keyword argument in the hacked_DownBlock2D_forward() and hacked_UpBlock2D_forward() functions. The signatures of these functions have been updated to include this argument, resolving the errors and enhancing overall functionality.
What does this PR do?
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.