Skip to content

Conversation

ryanrussell
Copy link
Contributor

Signed-off-by: Ryan Russell git@ryanrussell.org

Remaining one-off readability fixups in src/diffusers

Comments and docstrings

Signed-off-by: Ryan Russell <git@ryanrussell.org>
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 24, 2022

The documentation is not available anymore as the PR was closed or merged.

Signed-off-by: Ryan Russell <git@ryanrussell.org>
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot!

@@ -436,7 +436,7 @@ def from_pretrained(
)
cls._missing_keys = missing_keys

# Mistmatched keys contains tuples key/shape1/shape2 of weights in the checkpoint that have a shape not
# Mismatched keys contains tuples key/shape1/shape2 of weights in the checkpoint that have a shape not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like mismatched_keys was made obsolete in 73e0bc6. I'll open a new issue to clean it up.

@pcuenca pcuenca merged commit d0aa899 into huggingface:main Sep 24, 2022
@ryanrussell ryanrussell deleted the src-readability-oneoffs branch September 24, 2022 14:42
prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
* docs: `src/diffusers` readability improvements

Signed-off-by: Ryan Russell <git@ryanrussell.org>

* docs: `make style` lint

Signed-off-by: Ryan Russell <git@ryanrussell.org>

Signed-off-by: Ryan Russell <git@ryanrussell.org>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* docs: `src/diffusers` readability improvements

Signed-off-by: Ryan Russell <git@ryanrussell.org>

* docs: `make style` lint

Signed-off-by: Ryan Russell <git@ryanrussell.org>

Signed-off-by: Ryan Russell <git@ryanrussell.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants