-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Add IP-Adapter to StableDiffusionXLControlNetImg2ImgPipeline #6293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2c11c02
to
eb48d76
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@antoine-scenario run |
eb48d76
to
537b7fa
Compare
done 👍 |
@yiyixuxu could you take a look here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great! thank you :)
src/diffusers/pipelines/controlnet/pipeline_controlnet_sd_xl_img2img.py
Outdated
Show resolved
Hide resolved
can we fix the test? you need to add the optional image_encoder component (
|
Update src/diffusers/pipelines/controlnet/pipeline_controlnet_sd_xl_img2img.py Co-authored-by: YiYi Xu <yixu310@gmail.com> fix tests
@yiyixuxu I did the fix you suggested but the test still fails 😕 |
ok can we find out what's the difference? I think you can add some print lines here to find out (i.e. print out
|
do you have a command to run the test locally ? I followed the instructions from the doc and tried Otherwise in the CI the print doesn't show. |
@antoine-scenario |
oh yes you're right ! everything seems to be fine by now 😇 |
cc @sayakpaul for a final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice.
Brainstorming, not related to the PR: I wonder if we should work on a tutorial showing the different use cases of IP Adapters in light of various pipelines for which it's supported.
IP Adapters are getting increasingly popular, so I definitely think it's a good idea. @stevhliu WDYT?
Yes, IP Adapters quality is really good. |
We currently have a section for IP-Adapters here where we show off how to use it with various pipelines and for different tasks as well, so I don't necessarily think we need a new doc for it. But I think we can spin this section out into a standalone doc to increase visibility and keep adding to it. 🙂 |
…face#6293) * add IP-Adapter to StableDiffusionXLControlNetImg2ImgPipeline Update src/diffusers/pipelines/controlnet/pipeline_controlnet_sd_xl_img2img.py Co-authored-by: YiYi Xu <yixu310@gmail.com> fix tests * fix failing test --------- Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Add IP-Adapter to StableDiffusionXLControlNetImg2ImgPipeline as it was missing so far.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.