[gradient checkpointing] lower tolerance for test #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
| @@ -199,7 +199,7 @@ def prepare_init_args_and_inputs_for_common(self): | |||
|
|
|||
| def test_gradient_checkpointing(self): | |||
| init_dict, inputs_dict = self.prepare_init_args_and_inputs_for_common() | |||
| model = self.model_class(**init_dict) | |||
| model = self.model_class(**init_dict).eval() | |||
There was a problem hiding this comment.
nice! Let's be extra careful in the future to not just lower the test tolerance. Here I think it really was dropout that was messing up the grads
prathikr
pushed a commit
to prathikr/diffusers
that referenced
this pull request
Oct 26, 2022
* lowe tolerance * put model in eval mode
prathikr
pushed a commit
to prathikr/diffusers
that referenced
this pull request
Oct 26, 2022
* lowe tolerance * put model in eval mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lowers the tolerance for gradient checkpointing test.