Skip to content

Conversation

cosmo3769
Copy link
Contributor

What does this PR do?

Related issue: #6891 for T2I Sdxl

Notebook link: test_model_card_template_t2i_sdxl.ipynb

Generated model card link: test-model-card-template-t2i-sdxl

Before submitting

Who can review?

@sayakpaul

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

Optional for this PR: Can we also take this opportunity to fix the type annotation of the save_model_card() method:

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul merged commit 6f33665 into huggingface:main Feb 12, 2024
@cosmo3769
Copy link
Contributor Author

cosmo3769 commented Feb 12, 2024

Optional for this PR: Can we also take this opportunity to fix the type annotation of the save_model_card() method:

With one PR, should I also fix the type annotation for t2i, t2i-lora as well?

@sayakpaul
Copy link
Member

Yes sure. That will be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants