Skip to content

Conversation

sayakpaul
Copy link
Member

What does this PR do?

No idea why we didn't pass revision.

@sayakpaul sayakpaul requested review from DN6 and yiyixuxu February 19, 2024 04:06
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Feb 24, 2024

I don't think we need to pass down this argument since:

  1. load_sub_model is only used inside DiffusionPipeline.from_pretrained()
  2. we used the revision argument to download the correct checkpoints here, once we have the cached folder we don't need this argument anymore
    cached_folder = cls.download(

but I'm ok with this PR - I just don't think it makes any difference

@sayakpaul
Copy link
Member Author

You're absolutely right! WDYT about removing revision from load_sub_model() then? I think we should eliminate the confusion (it's not used in the method).

@DN6
Copy link
Collaborator

DN6 commented Feb 26, 2024

Yes, I think we can remove it from load_sub_model if it's not used.

@yiyixuxu
Copy link
Collaborator

yep on the same page - we can remove it

@sayakpaul
Copy link
Member Author

@yiyixuxu requesting for another review.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sayakpaul sayakpaul merged commit 848f9fe into main Feb 27, 2024
@sayakpaul sayakpaul deleted the pass-revision-down-the-line branch February 27, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants