-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Fix Tiling in ConsistencyDecoderVAE
#7290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Tiling in ConsistencyDecoderVAE
#7290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking solid.
I left a major comment on how we should expose the tiling arguments (init vs. via enable_vae_tiling()
).
Can we also add a test for this?
ConsistencyDecoderVAE
ConsistencyDecoderVAE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey! thanks for the PR.
it's looking great!
I left a feedback and additionally, could you add a test_vae_tiling test to ./tests/models/autoencoders/test_models_vae.py( similar to
def test_vae_tiling(self): |
…and overlap factor" This reverts commit 1810496.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Let's add a test as well?
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@StandardAI let us know when you are ready for a final review |
It seems to pass the test in Colab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment and once addressed, we can ship!
Please ping me once the CI run is done. |
|
Thank you for this impressive contribution! |
Thanks so much for reviewing and merging! |
* Fix typos * Add docstring to `decode` method in `ConsistencyDecoderVAE` * Fix tiling * Enable tiled VAE decoding with customizable tile sample size and overlap factor * Revert "Enable tiled VAE decoding with customizable tile sample size and overlap factor" This reverts commit 1810496. * Add VAE tiling test for `ConsistencyDecoderVAE` --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Fixes #6126.
This pull request includes three commits:
Fix tiling
Add docstring to
decode
method inConsistencyDecoderVAE
I tested with this:
Also, this PR passes
./tests/models/autoencoders/test_models_vae.py
tests in my local setup.@yiyixuxu @sayakpaul